Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IL Trimming should produce a warning for WPF and Winforms in .NET 6 #1933

Closed
agocke opened this issue Mar 31, 2021 · 3 comments
Closed

IL Trimming should produce a warning for WPF and Winforms in .NET 6 #1933

agocke opened this issue Mar 31, 2021 · 3 comments

Comments

@agocke
Copy link
Member

agocke commented Mar 31, 2021

Neither framework will be safe for trimming in .NET 6. Rather than show all the warnings, which won't be helpful, we should have one prominent warning that IL trimming is not supported for these application types.

We may also want to either warn about COM being disabled by default in WinForms, or enable it.
@marek-safar
Copy link
Contributor

Why do you think this should be handled specially by the linker and not by SDK?

@agocke
Copy link
Member Author

agocke commented Apr 1, 2021

This is probably better done in the SDK -- I just didn't think about it before filing the issue.

@agocke
Copy link
Member Author

agocke commented Apr 2, 2021

Duping with dotnet/sdk#16716

@agocke agocke closed this as completed Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marek-safar @agocke