Expose more services #8291
Merged
Expose more services #8291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
suggested changes
Jan 20, 2020
Contributor
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
Thanks, this is great! Very happy to have these services/APIs exposed. Some changes are in order here though, since what I think was acceptable as a VFT internal isn't quite good enough for a public API. If you're willing to make those changes/discuss the suggestions then this is definitely mergeable since the actual implementations themselves are fine for exposure.
Co-Authored-By: Phillip Carter <[email protected]>
Contributor
Author
|
Updated according to the feedback |
Contributor
|
@TIHan please review |
Contributor
|
let's yeet this puppy into the codebase |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* Expose simplify name analyzer * Move IsPrivateToFile to the FSharpSymbolUse from extensions * Expose Unused Declarations analyzer * Update src/fsharp/symbols/Symbols.fsi Co-Authored-By: Phillip Carter <[email protected]> * Apply feedback Co-authored-by: Phillip Carter <[email protected]>
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* Expose simplify name analyzer * Move IsPrivateToFile to the FSharpSymbolUse from extensions * Expose Unused Declarations analyzer * Update src/fsharp/symbols/Symbols.fsi Co-Authored-By: Phillip Carter <[email protected]> * Apply feedback Co-authored-by: Phillip Carter <[email protected]>
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* Expose simplify name analyzer * Move IsPrivateToFile to the FSharpSymbolUse from extensions * Expose Unused Declarations analyzer * Update src/fsharp/symbols/Symbols.fsi Co-Authored-By: Phillip Carter <[email protected]> * Apply feedback Co-authored-by: Phillip Carter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this PR does 3 things:
IsPrivateToFiletoFSharpSymbolUse- both for VS and FSAC we've been adding it as an extension, but since it's used in both places, I guess we may add it to the type directlyIn general, this PR will allow us to remove the whole bunch of code in FSAC that was copy-pasted from here.