Update System.Memory package only for source build #18188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ No release notes required |
KevinRansom
suggested changes
Dec 30, 2024
Contributor
KevinRansom
left a comment
KevinRansom
left a comment
There was a problem hiding this comment.
Please hold off from merging this for now. When I get back I will think about it.
KevinRansom
approved these changes
Jan 2, 2025
Contributor
KevinRansom
left a comment
KevinRansom
left a comment
There was a problem hiding this comment.
Yeah, this is probably the best way to take care of this for now. Someone should ensure that VS updates it's Memory and Buffers packages so that we can remove this.
T-Gro
approved these changes
Jan 2, 2025
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18187.
Inspired by https://github.com/dotnet/arcade/pull/15353/files
and https://github.com/dotnet/roslyn/blob/98ea496177bc8e607dbf454abd6b5a5e4678aed2/eng/Versions.props#L23-L44