Skip to content

Conversation

@brianrourkeboll
Copy link
Contributor

@brianrourkeboll brianrourkeboll commented May 22, 2024

Description

Fixes #17226.

  • Dotting into delegates with multiple type arguments would trigger an index out of range exception. Now it doesn't.

Checklist

  • Tests: I spent a while trying to get a test for this to work, but it seems like it might be rather difficult, since this pathway only seems to be called sometimes. Compare:

    // Use an environment lookup as the last resort
    let envItems, denv, m =
    GetEnvironmentLookupResolutions(nenv, ad, m, plid, filterCtors, residueOpt.IsSome)

    But here's a recording of the fix working:

    dot_delegate_working.mp4
  • Release notes entry updated.

* Dotting into delegates with multiple type arguments would trigger an
  index out of range exception. Now it doesn't.
@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2024

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.400.md

@brianrourkeboll brianrourkeboll marked this pull request as ready for review May 22, 2024 14:29
@brianrourkeboll brianrourkeboll requested a review from a team as a code owner May 22, 2024 14:29
Copy link
Member

@vzarytovskii vzarytovskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Internal error when dotting into delegate with 2 or more type parameters

2 participants