Remove unnecessary .NET Standard 1.x packages. #13856
Conversation
…ET Standard 2.0.
And add a note that warns against adding them back.
This includes the file `coreclr_utilities.fs` file, which does not seem to be needed since .NET Core 2.0.
teo-tsirpanis
force-pushed
the
package-cleanup
branch
from
72f2f53 to
01fd7cc
Compare
KevinRansom
left a comment
KevinRansom
left a comment
There was a problem hiding this comment.
I think these were all necessary when we still built netstandard 1.6. But probably serve no useful purpose now.
Thanks
|
CI currently fails because of some version conflicts caused by the removed packages. They will be fixed by updating dependencies to versions that target .NET Standard 2.0 which I will do later (couldn't catch it earlier, building fails on my machine with compiler errors). |
|
We will likely have to roll this one back, it causes build issues when merging to 17.4 |
|
What fails? Is there a log publicly available? |
Yeah, this is the merge PR: I will need to take a closer look at it though to be sure if this PR is the cause. |
|
I don't think this PR is to blame. That PR fails because the property |
Yeah, it seems just a weird merge resolution across multiple PRs |
3 participants
A continuation of #8898 (which was subsequently reverted for some reason) but on the entire repository, this PR removes references to NuGet packages from the .NET Standard 1.x era, reducing the amount of transitive dependencies of projects. I also updated two packages to versions that bring less of them, and a notice to
Versions.propsthat discourages adding more of these legacy packages.