Skip to content

Conversation

@dsyme
Copy link
Contributor

@dsyme dsyme commented May 5, 2022

  • Split TcAnonRecdExpr into two functions
  • ExtensionTyping.fs{i} --> TypeProviders.fs{i} plus remove indentation
  • Clarify some cases of confusing single character identifiers such as e --> expr or exn
  • Clarify some uses of "tick identifiers", e.g. body' --> bodyR
  • Some whitespace cleanup
  • Normalize and clarify some commonly occuring identifiers, e.g. rty --> retTy or other as necessary, bodyty --> bodyTy
  • Remove some uses of List.iter and Array.iter in favour of explicit for loops, which we generally prefer in the compiler.

Some general rules

  • Tick identifiers body' are not that great. They are generally harder to read and can't be inspected in the debugger as things stand. Generaly use R suffix instead, e.g. bodyR. The R can stand for "rewritten" or "result"
  • Abbreviations that run together lowercase like bodyty are bad, really hard to head for newcomers
  • Don't use List.iter and Array.iter in the compiler, a for loop is simpler

@dsyme dsyme changed the title [WIP] cleanup code cleanup May 5, 2022
@dsyme
Copy link
Contributor Author

dsyme commented May 6, 2022

@vzarytovskii This is ready for review

@vzarytovskii vzarytovskii merged commit f9b7206 into dotnet:main May 6, 2022
@dsyme dsyme mentioned this pull request May 6, 2022
charlesroddie pushed a commit to charlesroddie/fsharp that referenced this pull request May 2, 2023
* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants