Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update System.Memory to verson 4.5.5 #13395

Closed
lbussell opened this issue Jun 27, 2022 · 1 comment
Closed

Update System.Memory to verson 4.5.5 #13395

lbussell opened this issue Jun 27, 2022 · 1 comment
Labels
Engineering Feature Request
Milestone
Backlog

Comments

@lbussell
Copy link

See #13394 (comment)

The latest version of System.Memory is 4.5.5: https://www.nuget.org/packages/System.Memory. Referencing version 4.5.4 causes a package downgrade error since some of fsharp's dependencies rely on the newer version. See the dependency flow from the build failure:

FSharp.Build -> System.Memory (>= 4.5.4)
FSharp.Build -> Microsoft.Build.Tasks.Core 17.3.0-preview-22323-15 -> Microsoft.NET.StringTools 1.0.0-preview-22323-15 -> System.Memory (>= 4.5.5)

Upgrading this package prevents the package downgrade error in source-build.
This was referenced Jun 27, 2022
Closed
Merged
@vzarytovskii vzarytovskii moved this to Not Planned in F# Compiler and Tooling Jul 7, 2022
@vzarytovskii vzarytovskii added this to the Backlog milestone Jul 7, 2022
@vzarytovskii vzarytovskii linked a pull request Sep 21, 2022 that will close this issue
Fix #13906 #13943
Closed
@T-Gro
Copy link
Member

T-Gro commented Dec 21, 2022

This was done.

@T-Gro T-Gro closed this as completed Dec 21, 2022
Repository owner moved this from Not Planned to Done in F# Compiler and Tooling Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Engineering Feature Request
Projects
F# Compiler and Tooling
Archived in project
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Fix #13906 vzarytovskii/fsharp
4 participants
@vzarytovskii @dsyme @lbussell @T-Gro