Set DisableNETStandardCompatErrors in ServiceDiscovery libraries #6927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without setting this property, the NuGet pacakges will raise an error saying the libraries don't support net462. These libraries work correctly on .NET Framework and the unit tests are passing. So disable the NuGet MSBuild error.
eerhardt
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a property to two ServiceDiscovery project files to suppress NETStandard compatibility errors during packing.
- Introduces DisableNETStandardCompatErrors in the main ServiceDiscovery library.
- Mirrors the same property in the abstractions project to align behavior.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Libraries/Microsoft.Extensions.ServiceDiscovery/Microsoft.Extensions.ServiceDiscovery.csproj | Adds DisableNETStandardCompatErrors property to suppress NETStandard compatibility errors. |
| src/Libraries/Microsoft.Extensions.ServiceDiscovery.Abstractions/Microsoft.Extensions.ServiceDiscovery.Abstractions.csproj | Adds the same suppression property for consistency with the main library. |
...Libraries/Microsoft.Extensions.ServiceDiscovery/Microsoft.Extensions.ServiceDiscovery.csproj
Show resolved
Hide resolved
...ions.ServiceDiscovery.Abstractions/Microsoft.Extensions.ServiceDiscovery.Abstractions.csproj
Show resolved
Hide resolved
joperezr
approved these changes
Oct 16, 2025
This was referenced Nov 11, 2025
Merged
Merged
Merged
Merged
Open
Open
This was referenced Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without setting this property, the NuGet pacakges will raise an error saying the libraries don't support net462.
These libraries work correctly on .NET Framework and the unit tests are passing. So disable the NuGet MSBuild error.
cc @KalleOlaviNiemitalo
Microsoft Reviewers: Open in CodeFlow