Skip to content

Conversation

@pakrym
Copy link

@pakrym pakrym commented Nov 9, 2019

Updates implementation and most of the tests.

We need to decide on the new package name.

cc @anurse

@analogrelay
Copy link

@BrennanConroy can take a look for now. We'll get a meeting together to talk about the full plan for getting these in and shipping them somewhere.

@pakrym pakrym closed this Nov 12, 2019
@pakrym pakrym reopened this Nov 12, 2019
@pakrym
Copy link
Author

pakrym commented Nov 12, 2019

There is a bug with how ApiGEN generates namespaces, disabled ref assembly for now.

Copy link
Member

@BrennanConroy BrennanConroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a stack overflow somewhere when running tests

@analogrelay
Copy link

Ok, we're good to re-visit this :). I'll take a scan now.

@pakrym can you retarget to release/3.1 and change the package name to Microsoft.Extensions.Configuration.Azure.KeyVault.Secrets as per the discussed plan? Let me know if you need resources from our end (I can put someone on this if your bandwidth has changed ;)).

We'll also need to get the versioning working. This should be versioned 3.1.0-preview1 even though it's in a patch branch.

Once all that's in place, I'll throw servicing-consider on this and we should be able to get it through Tactics since the plan has been Director-approved.

@BrennanConroy BrennanConroy force-pushed the pakrym/new-keyvault-config branch from 8c64801 to d38de46 Compare January 6, 2020 18:10
@BrennanConroy BrennanConroy changed the base branch from master to release/3.1 January 6, 2020 18:10
@analogrelay analogrelay requested a review from JunTaoLuo January 6, 2020 23:20
@analogrelay
Copy link

analogrelay commented Jan 10, 2020

I'm not an expert on the functional changes though.

I have faith in your ability to read/review new code 😜.

@BrennanConroy
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@analogrelay analogrelay changed the title Port configuration provider to use the new Azure.Security.KeyVault.Secrets [New Azure Integration Pkgs] Port configuration provider to use the new Azure.Security.KeyVault.Secrets Jan 14, 2020
@analogrelay analogrelay added the servicing-consider Shiproom approval is required for the issue label Jan 14, 2020
@jamshedd jamshedd added servicing-approved and removed servicing-consider Shiproom approval is required for the issue labels Jan 16, 2020
@jamshedd
Copy link
Member

Approved for March.

…Extensions.Configuration.Azure.KeyVault.Secrets.csproj
@analogrelay analogrelay removed this from the 3.1.3 milestone Feb 18, 2020
@analogrelay
Copy link

We don't need this anymore! See aspnet/Announcements#408 .

Thanks again @pakrym

@mmitche mmitche deleted the pakrym/new-keyvault-config branch January 4, 2021 21:32
@ghost ghost locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.