-
Notifications
You must be signed in to change notification settings - Fork 845
[New Azure Integration Pkgs] Port configuration provider to use the new Azure.Security.KeyVault.Secrets #2618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@BrennanConroy can take a look for now. We'll get a meeting together to talk about the full plan for getting these in and shipping them somewhere. |
|
There is a bug with how ApiGEN generates namespaces, disabled ref assembly for now. |
BrennanConroy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a stack overflow somewhere when running tests
src/Configuration/Config.AzureKeyVault/test/AzureKeyVaultConfigurationTest.cs
Outdated
Show resolved
Hide resolved
src/Configuration/Config.KeyVault.Secrets/samples/EnvironmentSecretManager.cs
Outdated
Show resolved
Hide resolved
src/Configuration/Config.KeyVault.Secrets/src/AzureKeyVaultConfigurationProvider.cs
Outdated
Show resolved
Hide resolved
src/Configuration/Config.KeyVault.Secrets/src/AzureKeyVaultConfigurationProvider.cs
Outdated
Show resolved
Hide resolved
src/Configuration/Config.KeyVault.Secrets/test/AzureKeyVaultConfigurationTest.cs
Outdated
Show resolved
Hide resolved
src/Configuration/Config.KeyVault.Secrets/test/AzureKeyVaultConfigurationTest.cs
Outdated
Show resolved
Hide resolved
src/Configuration/Config.KeyVault.Secrets/test/AzureKeyVaultConfigurationTest.cs
Outdated
Show resolved
Hide resolved
src/Configuration/Config.KeyVault.Secrets/test/AzureKeyVaultConfigurationTest.cs
Outdated
Show resolved
Hide resolved
src/Configuration/Config.KeyVault.Secrets/test/AzureKeyVaultConfigurationTest.cs
Outdated
Show resolved
Hide resolved
|
Ok, we're good to re-visit this :). I'll take a scan now. @pakrym can you retarget to We'll also need to get the versioning working. This should be versioned Once all that's in place, I'll throw |
Co-Authored-By: Brennan <[email protected]>
Co-Authored-By: Brennan <[email protected]>
8c64801 to
d38de46
Compare
src/Configuration/Config.Azure.KeyVault.Secrets/Directory.Build.props
Outdated
Show resolved
Hide resolved
I have faith in your ability to read/review new code 😜. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
src/Configuration/Config.Azure.KeyVault.Secrets/src/AzureKeyVaultConfigurationExtensions.cs
Outdated
Show resolved
Hide resolved
|
Approved for March. |
....Azure.KeyVault.Secrets/src/Microsoft.Extensions.Configuration.Azure.KeyVault.Secrets.csproj
Outdated
Show resolved
Hide resolved
…Extensions.Configuration.Azure.KeyVault.Secrets.csproj
|
We don't need this anymore! See aspnet/Announcements#408 . Thanks again @pakrym |
Updates implementation and most of the tests.
We need to decide on the new package name.cc @anurse