Have dev packages produce non-stable package versions. (#4662)

Author: joperezr

eng/MSBuild/ProjectStaging.targets

@@ -17,7 +17,6 @@
 
   <!-- Amend the description based on stage -->
   <PropertyGroup>
-    <Description Condition="'$(Stage)' == 'dev'">DEVELOPMENT BUILD - DO NOT USE IN PRODUCTION - $(Description)</Description>
     <Description Condition="'$(Stage)' == 'obsolete'">OBSOLETE PACKAGE - $(Description)</Description>
   </PropertyGroup>
 

eng/Versions.props

@@ -12,7 +12,7 @@
     <!--
         When DotNetFinalVersionKind is set to 'release', this branch will produce stable outputs for 'Shipping' packages
     -->
-    <DotNetFinalVersionKind Condition="'$(DotNetFinalVersionKind)' == ''">release</DotNetFinalVersionKind>
+    <DotNetFinalVersionKind Condition="'$(DotNetFinalVersionKind)' == '' And '$(Stage)' != 'dev'">release</DotNetFinalVersionKind>
     <!-- Enabling this rule will cause build failures on undocumented public APIs. -->
     <SkipArcadeNoWarnCS1591>true</SkipArcadeNoWarnCS1591>
   </PropertyGroup>

src/Generators/Microsoft.Gen.MetricsReports/Directory.Build.props

@@ -0,0 +1,9 @@
+<Project>
+  <!-- In order to get the right package versions for projects that shouldn't stabilize, we need to set this property before
+  importing the root level Directory.Build.props file. This property should be kept in here, as opposed to moving it to
+  the project itself. -->
+  <PropertyGroup>
+    <Stage>dev</Stage>
+  </PropertyGroup>
+  <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)../'))" />
+</Project>

src/Generators/Microsoft.Gen.MetricsReports/Microsoft.Gen.MetricsReports.csproj

@@ -11,7 +11,6 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <Stage>dev</Stage>
     <MinCodeCoverage>65</MinCodeCoverage>
     <MinMutationScore>85</MinMutationScore>
   </PropertyGroup>

src/Libraries/Microsoft.AspNetCore.Testing/Directory.Build.props

@@ -0,0 +1,9 @@
+<Project>
+  <!-- In order to get the right package versions for projects that shouldn't stabilize, we need to set this property before
+  importing the root level Directory.Build.props file. This property should be kept in here, as opposed to moving it to
+  the project itself. -->
+  <PropertyGroup>
+    <Stage>dev</Stage>
+  </PropertyGroup>
+  <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)../'))" />
+</Project>

src/Libraries/Microsoft.AspNetCore.Testing/Microsoft.AspNetCore.Testing.csproj

@@ -12,7 +12,6 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <Stage>dev</Stage>
     <MinCodeCoverage>100</MinCodeCoverage>
     <MinMutationScore>100</MinMutationScore>
   </PropertyGroup>

src/Libraries/Microsoft.Extensions.Diagnostics.Probes/Directory.Build.props

@@ -0,0 +1,9 @@
+<Project>
+  <!-- In order to get the right package versions for projects that shouldn't stabilize, we need to set this property before
+  importing the root level Directory.Build.props file. This property should be kept in here, as opposed to moving it to
+  the project itself. -->
+  <PropertyGroup>
+    <Stage>dev</Stage>
+  </PropertyGroup>
+  <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)../'))" />
+</Project>

src/Libraries/Microsoft.Extensions.Diagnostics.Probes/Microsoft.Extensions.Diagnostics.Probes.csproj

@@ -12,7 +12,6 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <Stage>dev</Stage>
     <MinCodeCoverage>70</MinCodeCoverage>
     <MinMutationScore>75</MinMutationScore>
   </PropertyGroup>

src/Libraries/Microsoft.Extensions.Hosting.Testing/Directory.Build.props

@@ -0,0 +1,9 @@
+<Project>
+  <!-- In order to get the right package versions for projects that shouldn't stabilize, we need to set this property before
+  importing the root level Directory.Build.props file. This property should be kept in here, as opposed to moving it to
+  the project itself. -->
+  <PropertyGroup>
+    <Stage>dev</Stage>
+  </PropertyGroup>
+  <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)../'))" />
+</Project>

src/Libraries/Microsoft.Extensions.Hosting.Testing/Microsoft.Extensions.Hosting.Testing.csproj

@@ -13,7 +13,6 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <Stage>dev</Stage>
     <MinCodeCoverage>100</MinCodeCoverage>
     <MinMutationScore>90</MinMutationScore>
   </PropertyGroup>