[release/9.0-staging] Fix to #35212 - Query/Perf: Compile identifier lambdas passed to PopulateIncludeCollection rather than inline

[maumar]

Fixes #35212
Port of #35213

Description
In EF9 we changed the way we generate shapers in preparation for AOT scenarios. As part of these changes we started inlining some delegates passed to PopulateIncludeCollection (as well as couple other methods), rather than compiling them. For scenarios with large number of entities we see significant perf degradation when these delegates are inlined, as opposed to compiled (like we used to do in EF8). This change reverts to EF8 behavior.

Customer impact
Queries using collection navigation with significant amount of data suffer large performance degradation when compared with EF8. No good workaround.

How found
Multiple customer reports on 9.0.0.

Regression
Yes, from 8.0. Perf regression only, no functional regression here.

Testing
Ad-hoc perf testing with BenchmarkDotNet. Functional change already covered by numerous tests.

Risk
Low - essentially reverting back to EF8 behavior, quirk added.

Benchmarks

before the fix (but already with invoke fix and no interpretation)

Method	Async	Mean	Error	StdDev	Op/s	Gen0	Gen1	Allocated
MultiInclue	False	455.1 ms	8.94 ms	10.29 ms	2.197	11000.0000	6000.0000	67.92 MB
MultiInclue	True	435.4 ms	1.77 ms	1.66 ms	2.297	11000.0000	6000.0000	67.92 MB

after the fix:

Method	Async	Mean	Error	StdDev	Op/s	Gen0	Gen1	Allocated
MultiInclue	False	363.3 ms	6.72 ms	6.29 ms	2.752	9000.0000	3000.0000	58.51 MB
MultiInclue	True	351.9 ms	2.08 ms	1.74 ms	2.842	9000.0000	3000.0000	58.51 MB

This gets us pretty close to the EF8 numbers which were:

Method	Async	Mean	Error	StdDev	Op/s	Gen0	Gen1	Allocated
MultiInclue	False	297.1 ms	1.47 ms	1.30 ms	3.365	8000.0000	6000.0000	52.4 MB
MultiInclue	True	290.2 ms	3.76 ms	3.52 ms	3.446	8500.0000	6000.0000	52.4 MB