Add missing Converts when simplifying in funcletizer #35122
Merged
+61
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
force-pushed
the
FuncletizerConvert
branch
from
55c9347
to
926a33c
Compare
ajcvickers
reviewed
Nov 25, 2024
| @@ -2101,6 +2106,9 @@ static Expression RemoveConvert(Expression expression) | |||
| } | |||
| } | |||
|
|
|||
| private static Expression ConvertIfNeeded(Expression expression, Type type) | |||
| => expression.Type == type ? expression : Convert(expression, type); | |||
There was a problem hiding this comment.
Is exact type match correct here? Should derived types be allowed?
There was a problem hiding this comment.
Yeah, AFAIK there are scenarios where a Convert node is indeed needed when inserting a node of type Subclass into an expected context of Superclass... In any case, the worse case here from the exact type match is an extra unneeded Convert node where it shouldn't be needed - this still needs to be handled (since the user may always insert it explicitly via a cast)... So I think it's OK..
ajcvickers
approved these changes
Nov 25, 2024
roji
added a commit
to roji/efcore
that referenced
this pull request
Nov 25, 2024
Fixes dotnet#35095 (cherry picked from commit 3cae7a8)
roji
added a commit
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35095