[2.1.3] Use structural equality for concurrency check in in-memory database #12483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
force-pushed
the
LookieThere0627
branch
from
2cadf42
to
0887a13
Compare
|
@AndriySvyryd Slightly different version from the last one you reviewed--realized that we needed to change both the Delete and Update paths. Also added new tests. Will quirk in a separate commit. |
ajcvickers
changed the title
AndriySvyryd
approved these changes
Jun 27, 2018
Fixes #12214 Fix is to use structural equality all the time for concurrency checks. This matches more closely the way the check works on real database systems.
ajcvickers
force-pushed
the
LookieThere0627
branch
from
0887a13
to
cb4191d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12214
Fix is to use structural equality all the time for concurrency checks. This matches more closely the way the check works on real database systems.