Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Honor launchSettings.json #8695

Open
Tracked by #19587
bricelam opened this issue Jun 2, 2017 · 11 comments
Open
Tracked by #19587

Tools: Honor launchSettings.json #8695

bricelam opened this issue Jun 2, 2017 · 11 comments
Labels
area-tools consider-for-next-release punted-for-6.0 punted-for-7.0 Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints. type-enhancement
Milestone

Comments

@bricelam
Copy link
Contributor

bricelam commented Jun 2, 2017

The CLI added support for launchSettings.json in dotnet/cli#6617. Unfortunately, it only works with dotnet run and thus doesn't light up in our tooling.

If we want to honor launchSettings.json (particularly environment variables and command line arguments) in our tools, we'll have to look for and parse the file ourselves.

If we do this, we should also remove our existing logic that defaults the ASPNETCORE_ENVIRONMENT variable to Development.

@ajcvickers
Copy link
Member

@danroth27 @DamianEdwards @Eilon @divega It would be great to have launchSettings.json be something that would work when using EF tooling. However, we're not going to try to hack this in by trying to parse the file in our own code. Do you guys see this as something we should push the CLI team to support? If so, we'll file an issue for it in dotnet/cli.

@ajcvickers ajcvickers added this to the Backlog milestone Jun 5, 2017
@ajcvickers
Copy link
Member

@divega to file an issue on CLI side.

@divega
Copy link
Contributor

divega commented Jul 11, 2018

We need a reusable component that dotnet run, VS and us can use.

@divega
Copy link
Contributor

divega commented Jul 25, 2018

@divega
Copy link
Contributor

divega commented Oct 7, 2018

@mlorbetske is now tracking this in his list. Clearing up fields to decide what to do with this issue.

@divega divega removed their assignment Oct 7, 2018
@divega divega removed this from the 2.2.0 milestone Oct 7, 2018
@ajcvickers ajcvickers added this to the Backlog milestone Oct 8, 2018
@ajcvickers ajcvickers removed this from the Backlog milestone Nov 19, 2019
@ajcvickers ajcvickers added this to the 5.0.0 milestone Dec 2, 2019
@ajcvickers
Copy link
Member

See also #22190--we should do this at the same time.

@kewur
Copy link

kewur commented Feb 21, 2021

would love to be able to pass in the profile in launchSettings that has the environment variables rather than setting them in the terminal myself.

@ajcvickers ajcvickers modified the milestones: 6.0.0, Backlog May 5, 2021
@ajcvickers ajcvickers modified the milestones: Backlog, 7.0.0 Oct 22, 2021
@ajcvickers ajcvickers added punted-for-7.0 Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints. and removed propose-punt labels Jul 7, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0, Backlog Jul 7, 2022
@Bykiev
Copy link

Bykiev commented Jul 22, 2022

Hi, is any estimates when it'll be fixed?

@enrij
Copy link

enrij commented Mar 20, 2024

Just found out that this tip allows firing any dotnet ef command with -- --launch-profile YourProfile and it works perfectly. I just tested it out with dotnet ef migrations script.

Hope it helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-tools consider-for-next-release punted-for-6.0 punted-for-7.0 Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints. type-enhancement
Projects
None yet
Development

No branches or pull requests

8 participants