Make the 'foreign key column gets indexed' a IForeignKeyConvention

[BradBarnich]

I am porting a large schema to EF7. We have tables where it would be impractical to have a reverse index for every foreign key property. We know this is not a best practice, but we also don't delete from the primary table.

Having as a convention, we could easily remove it from the ConventionSet during model creation. We are already doing this for the CascadeDeleteConvention.

Currently had to do this: BradBarnich@46ca0d3

Is there another workaround?

[mejje]

My EF7 model hasn't created any automatic FK indices, I actually thought it was a deprecated feature since I haven't disabled anything but cascade delete as well. I'll try to find out why that happens.

[rowanmiller]

@smitpatel @AndriySvyryd where in the stack do we currently introduce indexes on FKs?

[smitpatel]

Here
https://github.com/aspnet/EntityFramework/blob/dev/src/Microsoft.EntityFrameworkCore/Metadata/Internal/InternalEntityTypeBuilder.cs#L1016

[AndriySvyryd]

It can be moved to a convention fairly easily

[rowanmiller]

Decided that we should handle this as part of #214. There may be other things that should be moved to a convention, and we may want to combine and/or split existing conventions too.

[AndriySvyryd]

This was fixed in ab9e75f