Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move analyzer tests to VerifyCS #30803

Closed
DoctorKrolic opened this issue May 1, 2023 · 1 comment · Fixed by #30814
Closed

Move analyzer tests to VerifyCS #30803

DoctorKrolic opened this issue May 1, 2023 · 1 comment · Fixed by #30814
Labels
area-analyzer closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. community-contribution customer-reported type-enhancement
Milestone

Comments

@DoctorKrolic
Copy link
Contributor

Current implementation of analyzers' tests is not actually that easy to read. Other analyzer-related repos in .NET ecosystem use Microsoft.CodeAnalysis.Testing library, which simplifies test setup process and allows to use visual markup for defining diagnostics locations. Using it in this repo will help with readability and simplify test setup for potential contributors in this field.

I fully acknowledge that analyzer area has one of the least priorities among other tasks. I am happy to contribute, so I just want team's approve on this change, since this is not that much trivial (+1 dependency and quite a bit of infrastructure rework, even though I strogly believe this will make it better).

@roji
Copy link
Member

roji commented May 2, 2023

As you wrote, I don't think there's a lot of value in investing in our analyzer test infrastructure - but if you'd like to work on this please go ahead.

@ajcvickers ajcvickers added this to the 8.0.0 milestone May 11, 2023
@ajcvickers ajcvickers added type-enhancement closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. area-analyzer customer-reported labels May 11, 2023
@ajcvickers ajcvickers modified the milestones: 8.0.0, 8.0.0-preview4, 8.0.0-preview5 May 26, 2023
@ajcvickers ajcvickers modified the milestones: 8.0.0-preview5, 8.0.0 Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-analyzer closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. community-contribution customer-reported type-enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants