Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema versioning pattern with Cosmos DB #23753

Open
alexeymarkov opened this issue Dec 22, 2020 · 4 comments
Open

Schema versioning pattern with Cosmos DB #23753

alexeymarkov opened this issue Dec 22, 2020 · 4 comments

Comments

@alexeymarkov
Copy link

Hello,

I would like to implement the schema versioning pattern with for EF Core Cosmos DB.
I do not care about missing properties in queries and indexes and just want to have a full backward compatibility with old versions and avoid service downtime.
So the idea was to add a shadow property "schema_version" to each entity and and to migrate the data if necessary during reading.

Questions:

  1. How to intercept data reading (I need to read and modify a pure JObject before EF builds a real entity from it)
  2. How to intercept data writing to add the shadow property

Thank you.

@alexeymarkov
Copy link
Author

I found a solution myself.

For intercept reading I replace CosmosClientWrapper in DbContext and override ExecuteSqlQueryAsync method.
The class is for internal purposes so I would like to have an official way to implement lazy migrations.

For intercept writing I override SaveChangesAsync in DbContext. Due to the bug that HasValueGenerator does not affect Update despite of configuring together with ValueGeneratedOnAddOrUpdate I have to set values for modified entities in SaveChangesAsync.
It would be good to see ValueGeneratedOnAddOrUpdate behaves as expected (not as ValueGeneratedOnAdd).

@Dazfl
Copy link

Dazfl commented Feb 24, 2021

I'm faced with the same problem at the moment ... schema versioning. I would love to see this feature added to EF Core for Cosmos DB.

@roji
Copy link
Member

roji commented Feb 24, 2021

Please upvote issues in this repo (thumbs up on top-most message) to indicate that you want it implemented.

@jhulbertpmn
Copy link

I’d love to see built-in support for this as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants