Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all dependencies of EFCore.Analyzers PrivateAssets=All #11752

Closed
natemcmaster opened this issue Apr 20, 2018 · 2 comments
Closed

Make all dependencies of EFCore.Analyzers PrivateAssets=All #11752

natemcmaster opened this issue Apr 20, 2018 · 2 comments
Labels
closed-duplicate

Comments

@natemcmaster
Copy link
Contributor

The package Microsoft.EntityFrameworkCore.Analyzers has two dependencies in its nuspec that it shouldn't. Analyzers typically should have no dependencies. The references to Roslyn packages are build-only dependencies so should be PrivateAssets="All"

cc @ajaybhargavb @smitpatel @ajcvickers

image
@natemcmaster natemcmaster mentioned this issue Apr 20, 2018
Open
@ajaybhargavb
Copy link
Contributor

Looks like this was already fixed. a8c34a6

@natemcmaster
Copy link
Contributor Author

Ah yup, should have known.

Closed as a dup of #11633

@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ajcvickers @smitpatel @ajaybhargavb @natemcmaster