Remove EF's ToListAsync() over IAsyncEnumerable (internal)

... as it's ambiguous with the once introduced into .NET

Author: roji

src/Shared/EnumerableExtensions.cs

@@ -125,19 +125,6 @@ public static bool Any(this IEnumerable source)
         return false;
     }
 
-    public static async Task<List<TSource>> ToListAsync<TSource>(
-        this IAsyncEnumerable<TSource> source,
-        CancellationToken cancellationToken = default)
-    {
-        var list = new List<TSource>();
-        await foreach (var element in source.WithCancellation(cancellationToken).ConfigureAwait(false))
-        {
-            list.Add(element);
-        }
-
-        return list;
-    }
-
     public static List<TSource> ToList<TSource>(this IEnumerable source)
         => source.OfType<TSource>().ToList();
 

test/EFCore.Tests/EFTest.cs

@@ -45,7 +45,7 @@ public async Task CompiledQueryAsync_throws_when_used_with_different_models()
         Assert.Equal(
             CoreStrings.CompiledQueryDifferentModel("c => c.Foos"),
             (await Assert.ThrowsAsync<InvalidOperationException>(
-                () => query(context2).ToListAsync())).Message);
+                () => query(context2).ToListAsync().AsTask())).Message);
 
         _ = await query(context1).ToListAsync();
     }