Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ArgumentNullException docs to JsonSerializer.SerializeAsync overloads #3961

Closed
alanisaac opened this issue Feb 29, 2020 · 0 comments · Fixed by #3962
Closed

Add ArgumentNullException docs to JsonSerializer.SerializeAsync overloads #3961

alanisaac opened this issue Feb 29, 2020 · 0 comments · Fixed by #3962
Labels
untriaged New issue has not been triaged by the area owner

Comments

@alanisaac
Copy link
Contributor

alanisaac commented Feb 29, 2020

From dotnet/runtime#32705 (comment)

In System.Text.Json, the methods:

JsonSerializer.SerializeAsync<TValue>(Stream utf8Json, TValue value, JsonSerializerOptions? options = null, CancellationToken cancellationToken = default)
JsonSerializer.SerializeAsync(Stream utf8Json, object? value, Type inputType, JsonSerializerOptions? options = null, CancellationToken cancellationToken = default)

Both throw an ArgumentNullException when utf8Json is null, and when inputType is null for the latter method. Update the docs to reflect this.

@dotnet-bot dotnet-bot added the untriaged New issue has not been triaged by the area owner label Feb 29, 2020
@alanisaac alanisaac changed the title Add ArgumentNullException to JsonSerializer.SerializeAsync overloads Add ArgumentNullException docs to JsonSerializer.SerializeAsync overloads Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
untriaged New issue has not been triaged by the area owner
Projects
None yet
2 participants