Emphasize about same anonymous types not being equal when from separate assemblies #38421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
BillWagner
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Thanks again @BartoszKlonowski
This looks great, with one small nit. I'll commit my suggestion and then 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #38353
It adds the note regarding the fact that two same assemblies can't be equal when defined in separate assemblies, due to
internalaccess set by default.Note that this PR also updates the summary table of default access modifiers. That is to have that given as a reference, as I couldn't find anything about the default access of an anonymous type anywhere else.
Internal previews