Skip to content

Conversation

@SeanKilleen
Copy link
Contributor

@SeanKilleen SeanKilleen commented Jun 9, 2022

In favor of a working example vs a note that requires follow-up.

Summary

  • Removes note (in favor of working example)
  • Introduces the empty classes in the examples
  • Notes why the classes are empty

Fixes #27902

In favor of updating the example along with the note.
@SeanKilleen SeanKilleen changed the title WIP: Add empty classes into the docs example Add empty classes into the docs example Jun 9, 2022
@SeanKilleen SeanKilleen mentioned this pull request Jun 9, 2022
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do like this improvement. This is @BillWagner's article though, so let's solicit his thoughts before merging.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good @SeanKilleen

I'll :shipit: now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing classes

4 participants