Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileStream.Position breaking change documentation should be deleted #40245

Closed
mriehm opened this issue Mar 28, 2024 · 1 comment · Fixed by #40776
Closed

FileStream.Position breaking change documentation should be deleted #40245

mriehm opened this issue Mar 28, 2024 · 1 comment · Fixed by #40776
Assignees
Labels
dotnet-fundamentals/svc Pri2 📌 seQUESTered Identifies that an issue has been imported into Quest.

Comments

@mriehm
Copy link

mriehm commented Mar 28, 2024

Describe the issue or suggestion

This article describes a breaking change that supposedly occurs in .NET 6:
https://learn.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/6.0/filestream-position-updates-after-readasync-writeasync-completion

However, it seems that breaking change was reverted before .NET 6 was released, so it is misleading to continue to list that breaking change. I think that article should be deleted.

The supposed breaking change is that FileStream.Position is now updated only after ReadAsync/WriteAsync completes in .NET 6. That breaking change article was drafted on May 5, 2021, but then there was a PR entitled 'Update position before ReadAsync starts, but fix it after incomplete read' on July 29, 2021. So, I think the breaking change article was just not revisited after this later PR.

I've run the sample code provided in the breaking change article on .NET 8, both Windows and WSL, and it matches the pre-.NET 6 behavior described in that article, not the .NET 6+ behavior described.


Document Details

Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.


Associated WorkItem - 250223

@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Mar 28, 2024
@gewarren gewarren self-assigned this Apr 2, 2024
@gewarren gewarren added 🗺️ reQUEST Triggers an issue to be imported into Quest. and removed ⌚ Not Triaged Not triaged Pri3 labels Apr 29, 2024
@sequestor sequestor bot added 📌 seQUESTered Identifies that an issue has been imported into Quest. and removed 🗺️ reQUEST Triggers an issue to be imported into Quest. labels Apr 30, 2024
@gewarren
Copy link
Contributor

gewarren commented May 6, 2024

Thanks @mriehm. I'm going to keep the breaking change article but update it according to dotnet/runtime#56531 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet-fundamentals/svc Pri2 📌 seQUESTered Identifies that an issue has been imported into Quest.
Projects
No open projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants