Skip to content

chore: enable invarient culture #8897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yufeih merged 4 commits into from
Jun 21, 2023
Merged

chore: enable invarient culture #8897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
556aef7
chore: enable invarient culture
yufeih Jun 21, 2023
2a34848
test(snapshot): update snapshots for e2a3b28d6132c1517879dd3dce58f10f…
yufeih Jun 21, 2023
1995fad
fix tests
yufeih Jun 21, 2023
bf922da
test(snapshot): update snapshots for 38cad5b72133c6e8f550b2d40904f876…
yufeih Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<TargetFrameworks Condition=" '$(ContinuousIntegrationBuild)' == 'true' ">$(TargetFrameworks);net8.0</TargetFrameworks>
<LangVersion>Latest</LangVersion>
<ImplicitUsings>enable</ImplicitUsings>
<InvariantGlobalization>true</InvariantGlobalization>
<SuppressNETCoreSdkPreviewMessage>true</SuppressNETCoreSdkPreviewMessage>
</PropertyGroup>

Expand Down
8 changes: 4 additions & 4 deletions test/Microsoft.DocAsCode.Dotnet.Tests/GenerateMetadataFromCSUnitTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1128,16 +1128,16 @@ public static void Rain(this Doll d, Doll another)
var extensionMethods = output.Items[0].Items[1].ExtensionMethods;
Assert.Equal(2, extensionMethods.Count);
{
Assert.Equal("Test1.FooImple`1.Test1.Extension.Eat``1", extensionMethods[1]);
var reference = output.References[extensionMethods[1]];
Assert.Equal("Test1.FooImple`1.Test1.Extension.Eat``1", extensionMethods[0]);
var reference = output.References[extensionMethods[0]];
Assert.False(reference.IsDefinition);
Assert.Equal("Test1.Extension.Eat``1(Test1.FooImple{``0})", reference.Definition);
Assert.Equal("Eat<T>(FooImple<T>)", string.Concat(reference.NameParts[SyntaxLanguage.CSharp].Select(n => n.DisplayName)));
Assert.Equal("Extension.Eat<T>(FooImple<T>)", string.Concat(reference.NameWithTypeParts[SyntaxLanguage.CSharp].Select(n => n.DisplayName)));
}
{
Assert.Equal("Test1.Foo{`0[]}.Test1.Extension.Play``2({T}[],{Way})", extensionMethods[0]);
var reference = output.References[extensionMethods[0]];
Assert.Equal("Test1.Foo{`0[]}.Test1.Extension.Play``2({T}[],{Way})", extensionMethods[1]);
var reference = output.References[extensionMethods[1]];
Assert.False(reference.IsDefinition);
Assert.Equal("Test1.Extension.Play``2(Test1.Foo{``0},``0,``1)", reference.Definition);
Assert.Equal("Play<T[], Way>(Foo<T[]>, T[], Way)", string.Concat(reference.NameParts[SyntaxLanguage.CSharp].Select(n => n.DisplayName)));
Expand Down
50 changes: 25 additions & 25 deletions test/docfx.Snapshot.Tests/SamplesTest.CSharp/xrefmap.verified.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,25 +718,6 @@ references:
fullName.vb: CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence.New
nameWithType: StaticAbstractMembersInInterfaces.RepeatSequence.RepeatSequence
nameWithType.vb: StaticAbstractMembersInInterfaces.RepeatSequence.New
- uid: CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence.op_Increment(CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence)
name: operator ++(RepeatSequence)
href: api/CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence.html#CSharp11_StaticAbstractMembersInInterfaces_RepeatSequence_op_Increment_CSharp11_StaticAbstractMembersInInterfaces_RepeatSequence_
commentId: M:CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence.op_Increment(CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence)
name.vb: op_Increment(RepeatSequence)
fullName: CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence.operator ++(CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence)
fullName.vb: CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence.op_Increment(CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence)
nameWithType: StaticAbstractMembersInInterfaces.RepeatSequence.operator ++(StaticAbstractMembersInInterfaces.RepeatSequence)
nameWithType.vb: StaticAbstractMembersInInterfaces.RepeatSequence.op_Increment(StaticAbstractMembersInInterfaces.RepeatSequence)
- uid: CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence.op_Increment*
name: operator ++
href: api/CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence.html#CSharp11_StaticAbstractMembersInInterfaces_RepeatSequence_op_Increment_
commentId: Overload:CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence.op_Increment
isSpec: "True"
name.vb: op_Increment
fullName: CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence.operator ++
fullName.vb: CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence.op_Increment
nameWithType: StaticAbstractMembersInInterfaces.RepeatSequence.operator ++
nameWithType.vb: StaticAbstractMembersInInterfaces.RepeatSequence.op_Increment
- uid: CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence.Text
name: Text
href: api/CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence.html#CSharp11_StaticAbstractMembersInInterfaces_RepeatSequence_Text
Expand All @@ -756,6 +737,25 @@ references:
isSpec: "True"
fullName: CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence.ToString
nameWithType: StaticAbstractMembersInInterfaces.RepeatSequence.ToString
- uid: CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence.op_Increment(CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence)
name: operator ++(RepeatSequence)
href: api/CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence.html#CSharp11_StaticAbstractMembersInInterfaces_RepeatSequence_op_Increment_CSharp11_StaticAbstractMembersInInterfaces_RepeatSequence_
commentId: M:CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence.op_Increment(CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence)
name.vb: op_Increment(RepeatSequence)
fullName: CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence.operator ++(CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence)
fullName.vb: CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence.op_Increment(CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence)
nameWithType: StaticAbstractMembersInInterfaces.RepeatSequence.operator ++(StaticAbstractMembersInInterfaces.RepeatSequence)
nameWithType.vb: StaticAbstractMembersInInterfaces.RepeatSequence.op_Increment(StaticAbstractMembersInInterfaces.RepeatSequence)
- uid: CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence.op_Increment*
name: operator ++
href: api/CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence.html#CSharp11_StaticAbstractMembersInInterfaces_RepeatSequence_op_Increment_
commentId: Overload:CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence.op_Increment
isSpec: "True"
name.vb: op_Increment
fullName: CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence.operator ++
fullName.vb: CSharp11.StaticAbstractMembersInInterfaces.RepeatSequence.op_Increment
nameWithType: StaticAbstractMembersInInterfaces.RepeatSequence.operator ++
nameWithType.vb: StaticAbstractMembersInInterfaces.RepeatSequence.op_Increment
- uid: CSharp8
name: CSharp8
href: api/CSharp8.html
Expand Down Expand Up @@ -825,6 +825,12 @@ references:
commentId: T:CSharp8.DefaultInterfaceMembers.Nested
fullName: CSharp8.DefaultInterfaceMembers.Nested
nameWithType: DefaultInterfaceMembers.Nested
- uid: CSharp8.DefaultInterfaceMembers.X
name: X
href: api/CSharp8.DefaultInterfaceMembers.html#CSharp8_DefaultInterfaceMembers_X
commentId: F:CSharp8.DefaultInterfaceMembers.X
fullName: CSharp8.DefaultInterfaceMembers.X
nameWithType: DefaultInterfaceMembers.X
- uid: CSharp8.DefaultInterfaceMembers.op_UnaryPlus(CSharp8.DefaultInterfaceMembers)
name: operator +(DefaultInterfaceMembers)
href: api/CSharp8.DefaultInterfaceMembers.html#CSharp8_DefaultInterfaceMembers_op_UnaryPlus_CSharp8_DefaultInterfaceMembers_
Expand All @@ -844,12 +850,6 @@ references:
fullName.vb: CSharp8.DefaultInterfaceMembers.+
nameWithType: DefaultInterfaceMembers.operator +
nameWithType.vb: DefaultInterfaceMembers.+
- uid: CSharp8.DefaultInterfaceMembers.X
name: X
href: api/CSharp8.DefaultInterfaceMembers.html#CSharp8_DefaultInterfaceMembers_X
commentId: F:CSharp8.DefaultInterfaceMembers.X
fullName: CSharp8.DefaultInterfaceMembers.X
nameWithType: DefaultInterfaceMembers.X
- uid: CSharp8.DisposableRefStructs
name: DisposableRefStructs
href: api/CSharp8.DisposableRefStructs.html
Expand Down
20 changes: 10 additions & 10 deletions test/docfx.Snapshot.Tests/SamplesTest.Seed/api/toc.html.view.verified.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,22 +339,22 @@
"level": 3.0
},
{
"name": "Cat<T, K>",
"href": "CatLibrary.Cat-2.html",
"topicHref": "CatLibrary.Cat-2.html",
"topicUid": "CatLibrary.Cat`2",
"name.vb": "Cat(Of T, K)",
"name": "CatException<T>",
"href": "CatLibrary.CatException-1.html",
"topicHref": "CatLibrary.CatException-1.html",
"topicUid": "CatLibrary.CatException`1",
"name.vb": "CatException(Of T)",
"tocHref": null,
"level": 3.0,
"items": [],
"leaf": true
},
{
"name": "CatException<T>",
"href": "CatLibrary.CatException-1.html",
"topicHref": "CatLibrary.CatException-1.html",
"topicUid": "CatLibrary.CatException`1",
"name.vb": "CatException(Of T)",
"name": "Cat<T, K>",
"href": "CatLibrary.Cat-2.html",
"topicHref": "CatLibrary.Cat-2.html",
"topicUid": "CatLibrary.Cat`2",
"name.vb": "Cat(Of T, K)",
"tocHref": null,
"level": 3.0,
"items": [],
Expand Down
2 changes: 1 addition & 1 deletion test/docfx.Snapshot.Tests/SamplesTest.Seed/api/toc.json.view.verified.json
View file
Open in desktop

Large diffs are not rendered by default.

14 changes: 7 additions & 7 deletions test/docfx.Snapshot.Tests/SamplesTest.Seed/api/toc.verified.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,20 +222,20 @@
}
]
},
{
"name": "Cat<T, K>",
"href": "CatLibrary.Cat-2.html",
"topicHref": "CatLibrary.Cat-2.html",
"topicUid": "CatLibrary.Cat`2",
"name.vb": "Cat(Of T, K)"
},
{
"name": "CatException<T>",
"href": "CatLibrary.CatException-1.html",
"topicHref": "CatLibrary.CatException-1.html",
"topicUid": "CatLibrary.CatException`1",
"name.vb": "CatException(Of T)"
},
{
"name": "Cat<T, K>",
"href": "CatLibrary.Cat-2.html",
"topicHref": "CatLibrary.Cat-2.html",
"topicUid": "CatLibrary.Cat`2",
"name.vb": "Cat(Of T, K)"
},
{
"name": "Complex<T, J>",
"href": "CatLibrary.Complex-2.html",
Expand Down
Loading