chore: dead code elimination

Author: yufeih

src/Docfx.App/Helpers/Constants.cs

@@ -6,8 +6,6 @@
 
 namespace Docfx;
 
-#pragma warning disable CS0618 // Type or member is obsolete
-
 /// <summary>
 /// Helper class to build document.
 /// </summary>
@@ -20,7 +18,7 @@ public static string Exec(BuildJsonConfig config, BuildOptions options, string c
     {
         if (config.Template == null || config.Template.Count == 0)
         {
-            config.Template = new ListWithStringFallback { Constants.DefaultTemplateName };
+            config.Template = new ListWithStringFallback { "default" };
         }
 
         var baseDirectory = Path.GetFullPath(string.IsNullOrEmpty(configDirectory) ? Directory.GetCurrentDirectory() : configDirectory);

src/Docfx.App/RunBuild.cs

@@ -9,7 +9,7 @@
 
 namespace Docfx.Build.Engine;
 
-internal class HostServiceCreator : IHostServiceCreator
+class HostServiceCreator
 {
     private readonly DocumentBuildContext _context;
 

src/Docfx.Build/HostServiceCreator.cs

@@ -87,10 +87,10 @@ private InternalManifestItem HandleSaveResult(
         SaveResult result)
     {
         Context.SetFilePath(model.Key, ((RelativePath)model.File).GetPathFromWorkingFolder());
-        DocumentException.RunAll(
-            () => CheckFileLink(model, hostService, result),
-            () => HandleUids(result),
-            () => RegisterXRefSpec(result));
+
+        CheckFileLink(model, hostService, result);
+        HandleUids(result);
+        RegisterXRefSpec(result);
 
         return GetManifestItem(model, result);
     }

src/Docfx.Build/IHostServiceCreator.cs

@@ -16,15 +16,12 @@ public sealed class ValidateBookmark : HtmlDocumentHandler
     /// <summary>
     /// bookmarks mapping from output file -> bookmarks
     /// </summary>
-    private readonly OSPlatformSensitiveDictionary<HashSet<string>> _registeredBookmarks =
-        new();
+    private readonly Dictionary<string, HashSet<string>> _registeredBookmarks = new(FilePathComparer.OSPlatformSensitiveStringComparer);
     /// <summary>
     /// file mapping from output file -> src file
     /// </summary>
-    private readonly OSPlatformSensitiveDictionary<string> _fileMapping =
-        new();
-    private readonly OSPlatformSensitiveDictionary<List<LinkItem>> _linksWithBookmark =
-        new();
+    private readonly Dictionary<string, string> _fileMapping = new(FilePathComparer.OSPlatformSensitiveStringComparer);
+    private readonly Dictionary<string, List<LinkItem>> _linksWithBookmark = new(FilePathComparer.OSPlatformSensitiveStringComparer);
 
     #region IHtmlDocumentHandler members
 

src/Docfx.Build/LinkPhaseHandler.cs

@@ -56,13 +56,12 @@ public Manifest Build(DocumentBuildParameters parameters, IMarkdownService markd
 
         // Start building document...
         List<HostService> hostServices = null;
-        IHostServiceCreator hostServiceCreator = null;
         try
         {
             using var templateProcessor = parameters.TemplateManager?.GetTemplateProcessor(context, parameters.MaxParallelism)
                                           ?? new TemplateProcessor(new EmptyResourceReader(), context, 16);
 
-            hostServiceCreator = new HostServiceCreator(context);
+            var hostServiceCreator = new HostServiceCreator(context);
             hostServices = GetInnerContexts(parameters, Processors, templateProcessor, hostServiceCreator, markdownService);
 
             templateProcessor.CopyTemplateResources(context.ApplyTemplateSettings);
@@ -100,7 +99,7 @@ private List<HostService> GetInnerContexts(
         DocumentBuildParameters parameters,
         IEnumerable<IDocumentProcessor> processors,
         TemplateProcessor templateProcessor,
-        IHostServiceCreator creator,
+        HostServiceCreator creator,
         IMarkdownService markdownService)
     {
         var files = (from file in parameters.Files.EnumerateFiles().AsParallel().WithDegreeOfParallelism(parameters.MaxParallelism)