Skip to content

Commit 64ba963

Browse files
yufeihyufeih
authored
fix: class level seealso leaked to members (#9491)
* fix: class level seealso leaked to members * test(snapshot): update snapshots f845ba5 for ubuntu-latest * test(snapshot): update snapshots f845ba5 for windows-latest --------- Co-authored-by: yufeih <[email protected]>
1 parent 2324f13 commit 64ba963

File tree

253 files changed

+7962
-4395
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

253 files changed

+7962
-4395
lines changed

‎samples/seed/dotnet/project/Project/Class1.cs‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,4 +202,15 @@ public ExperimentalAttribute(string diagnosticId)
202202

203203
public string DiagnosticId { get; }
204204
public string? UrlFormat { get; set; }
205-
}
205+
}
206+
207+
/// <summary>A nice class</summary>
208+
/// <seealso cref="Class1"/>
209+
public class Issue8725
210+
{
211+
/// <summary>A nice operation</summary>
212+
public void MyOperation() {}
213+
214+
/// <summary>Another nice operation</summary>
215+
public void MoreOperations() {}
216+
}

‎templates/common/ManagedReference.common.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,7 @@ function handleItem(vm, gitContribute, gitUrlPattern) {
199199
vm.syntax = vm.syntax || "";
200200
vm.implements = vm.implements || "";
201201
vm.example = vm.example || "";
202+
vm.seealso = vm.seealso || [];
202203
common.processSeeAlso(vm);
203204

204205
// id is used as default template's bookmark

‎test/docfx.Snapshot.Tests/SamplesTest.CSharp.Linux/api/CSharp10.ConstantInterpolatedStrings.html.view.verified.json‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@
184184
"conceptual": "",
185185
"implements": "",
186186
"example": "",
187-
"seealso": null,
187+
"seealso": [],
188188
"id": "CSharp10_ConstantInterpolatedStrings_S1",
189189
"hideTitleType": false,
190190
"hideSubtitle": false
@@ -318,7 +318,7 @@
318318
"conceptual": "",
319319
"implements": "",
320320
"example": "",
321-
"seealso": null,
321+
"seealso": [],
322322
"id": "CSharp10_ConstantInterpolatedStrings_S2",
323323
"hideTitleType": false,
324324
"hideSubtitle": false
@@ -452,7 +452,7 @@
452452
"conceptual": "",
453453
"implements": "",
454454
"example": "",
455-
"seealso": null,
455+
"seealso": [],
456456
"id": "CSharp10_ConstantInterpolatedStrings_S3",
457457
"hideTitleType": false,
458458
"hideSubtitle": false
@@ -1090,7 +1090,7 @@
10901090
"conceptual": "",
10911091
"implements": "",
10921092
"example": "",
1093-
"seealso": null,
1093+
"seealso": [],
10941094
"id": "CSharp10_ConstantInterpolatedStrings",
10951095
"hideTitleType": false,
10961096
"hideSubtitle": false,

‎test/docfx.Snapshot.Tests/SamplesTest.CSharp.Linux/api/CSharp10.Issue7737.html.view.verified.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@
182182
"remarks": "",
183183
"conceptual": "",
184184
"implements": "",
185-
"seealso": null,
185+
"seealso": [],
186186
"id": "CSharp10_Issue7737_Foo",
187187
"hideTitleType": false,
188188
"hideSubtitle": false
@@ -820,7 +820,7 @@
820820
"conceptual": "",
821821
"implements": "",
822822
"example": "",
823-
"seealso": null,
823+
"seealso": [],
824824
"id": "CSharp10_Issue7737",
825825
"hideTitleType": false,
826826
"hideSubtitle": false,

‎test/docfx.Snapshot.Tests/SamplesTest.CSharp.Linux/api/CSharp10.ParameterlessStructConstructors.html.view.verified.json‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@
182182
"conceptual": "",
183183
"implements": "",
184184
"example": "",
185-
"seealso": null,
185+
"seealso": [],
186186
"id": "CSharp10_ParameterlessStructConstructors__ctor",
187187
"hideTitleType": false,
188188
"hideSubtitle": false
@@ -323,7 +323,7 @@
323323
"conceptual": "",
324324
"implements": "",
325325
"example": "",
326-
"seealso": null,
326+
"seealso": [],
327327
"id": "CSharp10_ParameterlessStructConstructors_X",
328328
"hideTitleType": false,
329329
"hideSubtitle": false
@@ -509,7 +509,7 @@
509509
"conceptual": "",
510510
"implements": "",
511511
"example": "",
512-
"seealso": null,
512+
"seealso": [],
513513
"id": "CSharp10_ParameterlessStructConstructors_Description",
514514
"hideTitleType": false,
515515
"hideSubtitle": false
@@ -688,7 +688,7 @@
688688
"conceptual": "",
689689
"implements": "",
690690
"example": "",
691-
"seealso": null,
691+
"seealso": [],
692692
"id": "CSharp10_ParameterlessStructConstructors_Y",
693693
"hideTitleType": false,
694694
"hideSubtitle": false
@@ -1225,7 +1225,7 @@
12251225
"conceptual": "",
12261226
"implements": "",
12271227
"example": "",
1228-
"seealso": null,
1228+
"seealso": [],
12291229
"id": "CSharp10_ParameterlessStructConstructors",
12301230
"hideTitleType": false,
12311231
"hideSubtitle": false,

‎test/docfx.Snapshot.Tests/SamplesTest.CSharp.Linux/api/CSharp10.ReadOnlyRecordStruct.html.view.verified.json‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,7 @@
322322
"conceptual": "",
323323
"implements": "",
324324
"example": "",
325-
"seealso": null,
325+
"seealso": [],
326326
"id": "CSharp10_ReadOnlyRecordStruct__ctor_System_Double_System_Double_System_Double_",
327327
"hideTitleType": false,
328328
"hideSubtitle": false
@@ -508,7 +508,7 @@
508508
"conceptual": "",
509509
"implements": "",
510510
"example": "",
511-
"seealso": null,
511+
"seealso": [],
512512
"id": "CSharp10_ReadOnlyRecordStruct_X",
513513
"hideTitleType": false,
514514
"hideSubtitle": false
@@ -687,7 +687,7 @@
687687
"conceptual": "",
688688
"implements": "",
689689
"example": "",
690-
"seealso": null,
690+
"seealso": [],
691691
"id": "CSharp10_ReadOnlyRecordStruct_Y",
692692
"hideTitleType": false,
693693
"hideSubtitle": false
@@ -866,7 +866,7 @@
866866
"conceptual": "",
867867
"implements": "",
868868
"example": "",
869-
"seealso": null,
869+
"seealso": [],
870870
"id": "CSharp10_ReadOnlyRecordStruct_Z",
871871
"hideTitleType": false,
872872
"hideSubtitle": false
@@ -1448,7 +1448,7 @@
14481448
"remarks": "",
14491449
"conceptual": "",
14501450
"example": "",
1451-
"seealso": null,
1451+
"seealso": [],
14521452
"id": "CSharp10_ReadOnlyRecordStruct",
14531453
"hideTitleType": false,
14541454
"hideSubtitle": false,

‎test/docfx.Snapshot.Tests/SamplesTest.CSharp.Linux/api/CSharp10.RecordClass.html.view.verified.json‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@
276276
"conceptual": "",
277277
"implements": "",
278278
"example": "",
279-
"seealso": null,
279+
"seealso": [],
280280
"id": "CSharp10_RecordClass__ctor_System_String_System_String_",
281281
"hideTitleType": false,
282282
"hideSubtitle": false
@@ -462,7 +462,7 @@
462462
"conceptual": "",
463463
"implements": "",
464464
"example": "",
465-
"seealso": null,
465+
"seealso": [],
466466
"id": "CSharp10_RecordClass_FirstName",
467467
"hideTitleType": false,
468468
"hideSubtitle": false
@@ -641,7 +641,7 @@
641641
"conceptual": "",
642642
"implements": "",
643643
"example": "",
644-
"seealso": null,
644+
"seealso": [],
645645
"id": "CSharp10_RecordClass_LastName",
646646
"hideTitleType": false,
647647
"hideSubtitle": false
@@ -1324,7 +1324,7 @@
13241324
"remarks": "",
13251325
"conceptual": "",
13261326
"example": "",
1327-
"seealso": null,
1327+
"seealso": [],
13281328
"id": "CSharp10_RecordClass",
13291329
"hideTitleType": false,
13301330
"hideSubtitle": false,

‎test/docfx.Snapshot.Tests/SamplesTest.CSharp.Linux/api/CSharp10.RecordStruct.html.view.verified.json‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@
276276
"conceptual": "",
277277
"implements": "",
278278
"example": "",
279-
"seealso": null,
279+
"seealso": [],
280280
"id": "CSharp10_RecordStruct__ctor_System_DateTime_System_Double_",
281281
"hideTitleType": false,
282282
"hideSubtitle": false
@@ -462,7 +462,7 @@
462462
"conceptual": "",
463463
"implements": "",
464464
"example": "",
465-
"seealso": null,
465+
"seealso": [],
466466
"id": "CSharp10_RecordStruct_Measurement",
467467
"hideTitleType": false,
468468
"hideSubtitle": false
@@ -641,7 +641,7 @@
641641
"conceptual": "",
642642
"implements": "",
643643
"example": "",
644-
"seealso": null,
644+
"seealso": [],
645645
"id": "CSharp10_RecordStruct_TakenAt",
646646
"hideTitleType": false,
647647
"hideSubtitle": false
@@ -1223,7 +1223,7 @@
12231223
"remarks": "",
12241224
"conceptual": "",
12251225
"example": "",
1226-
"seealso": null,
1226+
"seealso": [],
12271227
"id": "CSharp10_RecordStruct",
12281228
"hideTitleType": false,
12291229
"hideSubtitle": false,

‎test/docfx.Snapshot.Tests/SamplesTest.CSharp.Linux/api/CSharp10.html.view.verified.json‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
"syntax": "",
6565
"implements": "",
6666
"example": "",
67-
"seealso": null,
67+
"seealso": [],
6868
"id": "CSharp10_ConstantInterpolatedStrings",
6969
"hideTitleType": false,
7070
"hideSubtitle": false
@@ -125,7 +125,7 @@
125125
"syntax": "",
126126
"implements": "",
127127
"example": "",
128-
"seealso": null,
128+
"seealso": [],
129129
"id": "CSharp10_Issue7737",
130130
"hideTitleType": false,
131131
"hideSubtitle": false
@@ -186,7 +186,7 @@
186186
"syntax": "",
187187
"implements": "",
188188
"example": "",
189-
"seealso": null,
189+
"seealso": [],
190190
"id": "CSharp10_RecordClass",
191191
"hideTitleType": false,
192192
"hideSubtitle": false
@@ -254,7 +254,7 @@
254254
"syntax": "",
255255
"implements": "",
256256
"example": "",
257-
"seealso": null,
257+
"seealso": [],
258258
"id": "CSharp10_ParameterlessStructConstructors",
259259
"hideTitleType": false,
260260
"hideSubtitle": false
@@ -315,7 +315,7 @@
315315
"syntax": "",
316316
"implements": "",
317317
"example": "",
318-
"seealso": null,
318+
"seealso": [],
319319
"id": "CSharp10_ReadOnlyRecordStruct",
320320
"hideTitleType": false,
321321
"hideSubtitle": false
@@ -376,7 +376,7 @@
376376
"syntax": "",
377377
"implements": "",
378378
"example": "",
379-
"seealso": null,
379+
"seealso": [],
380380
"id": "CSharp10_RecordStruct",
381381
"hideTitleType": false,
382382
"hideSubtitle": false
@@ -548,7 +548,7 @@
548548
"syntax": "",
549549
"implements": "",
550550
"example": "",
551-
"seealso": null,
551+
"seealso": [],
552552
"id": "CSharp10",
553553
"hideTitleType": false,
554554
"hideSubtitle": false,

0 commit comments

Comments
 (0)