-
Notifications
You must be signed in to change notification settings - Fork 385
Description
PR #2050 add TcpIP support into ReverseDiagnosticsServer. Part of that PR only enables it for the dsrouter components and prevent other tools to use it by adding a specific constructor to ReverseDiagnosticsServer that needs to be used in order to enable TcpIP support. It was done this way to limit the ability to start TcpIP listeners as part of existing tooling using ReverseDiagnosticsServer (dotnet-counters, dotnet-trace).
By removing this limitation we could open up the possibility to run ReverseDiagnosticsServer using TcpIP listener instead of NamedPipes/UnixDomainSockets, in all tools currently working with the reverse connect scenarios for runtime supporting diagnostics server TcpIP transports . This would enable users to use the --diagnostic-ports argument with a TcpIP endpoint, like tcp://127.0.0.1:x and if detected as a valid TcpIP address ReverseDiagnosticsServer will use TcpIp transport instead of NamedPipes or UnixDomainSockets.
/CC @josalem @shirhatti