Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

[Question] Assembly loading #6949

Open
alpencolt opened this issue Feb 4, 2019 · 13 comments
Open

[Question] Assembly loading #6949

alpencolt opened this issue Feb 4, 2019 · 13 comments

Comments

@alpencolt
Copy link

I'm interesting in assembly loading functional Assembly.LoadFile(). How it can implemented and will it be implemented? I see two ways how to do it:

cc @jkotas @kvochko @iarischenko @kbaladurin

@jkotas
Copy link
Member

jkotas commented Feb 4, 2019

First option is using interpreter

Interpreter (https://github.com/dotnet/corert/tree/master/src/System.Private.Interpreter/src) or JIT (https://github.com/dotnet/corert/tree/master/src/System.Private.Jit/src). They have different performance characteristics, but otherwise pretty equivalent.

Native Library mode

Loading libraries compiled in native library mode is not really Assembly.LoadFile equivalent. The native library can communicate with the rest of the world using native exported entrypoint only. You would not be able to seamlesly exchange objects between the program and the native library - each of them would have its own copy of System.Object, etc.

@alpencolt
Copy link
Author

Oh, I see...
What is the status of Interpreter and JIT? It looks interpreter has a lot of unimplemented instructions, e.g. work with objects.
Also if we try using Interpreter or JIT and load library which call some API from CoreFX, where it will take these classes?

@jkotas
Copy link
Member

jkotas commented Feb 4, 2019

Interpreter and JIT

Both are early prototypes. A lot of work to finish.

if we try using Interpreter or JIT and load library which call some API from CoreFX, where it will take these classes?

You can either full AOT compile the whole CoreFX (very big binary), or you can use partial AOT scheme like what CoreCLR does and fill in the missing methods using interpreter or JIT.

@alpencolt
Copy link
Author

or you can use partial AOT scheme like what CoreCLR does and fill in the missing methods using interpreter or JIT

An in this case we have to keep all system DLL, right?

@jkotas
Copy link
Member

jkotas commented Feb 4, 2019

Right. It becomes very much like what CoreCLR looks today.

@alpencolt
Copy link
Author

@jkotas could you say how how JIT will work by your design. Will it generate machine code directly to memory (like RuyJIT does it) or some other way? I can't find code generation in current implementation.

@MichalStrehovsky
Copy link
Member

The instructions for running the JIT prototype are here: #6327. It only works on Windows right now. Hopefully it didn't bitrot yet: you should be able to step through it. This is using RyuJIT as the JIT (a lot of the managed infrastructure that communicates with RyuJIT is shared with the CoreRT AOT compiler).

The part where we do code generation is around here:

@alpencolt
Copy link
Author

@MichalStrehovsky it sounds great! do you have any stats about passed CoreCLR/FX tests?

@MichalStrehovsky
Copy link
Member

I don't think anyone tried to run tests with this.

@alpencolt
Copy link
Author

But this way looks more robust then new JIT compiler

@NotoriousRebel
Copy link

Are there any examples or blog posts utilizing the interpreter or JIT?

@MichalStrehovsky
Copy link
Member

#6182 has the interpreter instructions but the interpreter is not ready for serious workloads.

We stopped building the JIT prototype a couple days ago because there was an issue blocking an integration from the dotnet/runtime repo and stopping the builds was the fastest thing to do to get things unblocked. The JIT prototype has similar limitations to the interpreter prototype.

@NotoriousRebel
Copy link

Interesting! Thanks for the quick reply, I cloned corert and built it then built the IL interpreter. Then created a new project with .NET Core 3.1 console app and added the System.Private.Interpreter as a reference DLL. Then started reading issue 5011 and am trying to wrap my head around creating a simple example :).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants