This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Disable build of System.Net.Http.WinHttpHandler to avoid problem on net461 #42908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forget, are any packageIndex changes needed? |
|
nope, We didn't change anything (meaning baselineVersion) for this package on the index because nobody depended on it so it wasn't required. |
wtgodbe
approved these changes
Apr 21, 2020
|
/azp run corefx-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Anipik
approved these changes
Apr 21, 2020
|
Seems like Github is still having some issues with badges, Here is the link the the build of my PR which is actually ongoing right now: https://dev.azure.com/dnceng/public/_build/results?buildId=610408 I will add a comment once it is done and notify it was all passing or not. |
|
Were some test failures on the first run, I hit retry |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @wtgodbe @Anipik @mmitche @ericstj
This will undo the build of System.Net.Http.WinHttpHandler
FYI: @karelz @alnikola as this affects #42888 fix.