Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

[release/2.1] Remove throw in exception handling of dispose #42489

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

yukiwongky
Copy link
Contributor

@yukiwongky yukiwongky commented Nov 8, 2019

Back port a fix from Microsoft.Data.Sqlclient issue #20. Recent issues: https://github.com/dotnet/corefx/issues/42586

The same PR #42457 is already merged on master branch.

2.1 Servicing:

Summary

User gets System.IO.IOException: Unable to write data to the transport connection: Broken pipe.
with or without MARS enabled

Customer Impact

Users using older verions of EFCore (< 3.0) cannot use Microsoft.Data.SqlClient. They need this change in order to not get the Unable to write data to the transport connection: Broken pipe error intermittently.

This has recently been escalated by the field, working with an ISV customer. Have not yet verified the version they are deployed on.

Also there's several recent customer reports - about 8 distinct reports in the linked issue eg
dotnet/SqlClient#20 (comment)
dotnet/SqlClient#20 (comment)
Most of these customers seem to be on 2.2, not 2.1.

Regression?

No, this exist in 2.0 as well.

Risk

Low: The code change is already in Microsoft.Data.SqlClient, and users have reported the fix works for them.

@danmoseley
Copy link
Member

danmoseley commented Nov 8, 2019

@yukiwongky , please edit the top post to add a template similar to the one here #42482 (comment)
Then set servicing-consider label.
Note, the 2.1 bar is much higher -- as this is an LTS release, we aim to keep it stable. We would need evidence of significant customer problems without a good workaround.

@stephentoub stephentoub changed the title Remove throw in exception handling of dispose [release/2.1] Remove throw in exception handling of dispose Nov 8, 2019
@cheenamalhotra cheenamalhotra added the Servicing-consider Issue for next servicing release review label Nov 14, 2019
@ViktorHofer ViktorHofer added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Nov 14, 2019
@danmoseley
Copy link
Member

@yukiwongky / @cheenamalhotra is there a customer escalated issue through support? If not this may go only into 3.1.

@cheenamalhotra
Copy link
Member

cheenamalhotra commented Nov 25, 2019

We have customer cases here:
dotnet/SqlClient#20 (comment)
dotnet/SqlClient#20 (comment)

(Many others in the same thread)

@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 26, 2019
@leecow leecow added this to the 2.1.16 milestone Nov 26, 2019
@danmoseley
Copy link
Member

This should go into only 2.1 and 3.1. (2.2 and 3.0 will be shortly out of support)

@danmoseley
Copy link
Member

@Anipik is it OK to merge this? for 2.1.16

@cheenamalhotra this is also approved for 3.1. (Not 2.2 or 3.0). Please go ahead and create a PR for 3.1 if there isn't one, and check with @Anipik when it's OK to merge. Consider it approved.

@vivmishra
Copy link

Moved to Mar as per Tactics. Will need to be explicitly approved for Feb, if required.

@vivmishra vivmishra modified the milestones: 2.1.16, 2.1.17 Jan 9, 2020
@danmoseley danmoseley removed the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Jan 14, 2020
@danmoseley danmoseley modified the milestones: 2.1.17, 2.1.16 Jan 14, 2020
@danmoseley
Copy link
Member

Moved back to 2.1.16 per tactics.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants