Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Commit

Permalink
Restore missing native *.ni.pdb file from the Microsoft.NETCore.Runti…
Browse files Browse the repository at this point in the history
…me.CoreCLR (#12677)

Restore missing native *.ni.pdb file from the Microsoft.NETCore.Runtime.CoreCLR package

DLLs that have native code, need both the *.pdb (for IL information) and the *.ni.pdb (for
native information).

When System.Private.Corlib was renamed from System.Private.Corlib.ni.pdb to System.Private.Corlib,
the logic that decides what goes into the  Microsoft.NETCore.Runtime.CoreCLR package lost
the *.ni.pdb for System.Private.Corlib.

This change basically causes this logic to search both for *.ni.pdb as well as the *.pdb file and
thus fixes this issue.
  • Loading branch information
mikem8361 committed Aug 23, 2017
1 parent 089fe7b commit 3512bb3
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/.nuget/dir.targets
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@
<WindowsNativeFile Include="@(NativeWithSymbolFile)"
Condition="'%(NativeWithSymbolFile.Extension)'=='.dll' OR '%(NativeWithSymbolFile.Extension)'=='.exe'" />
<WindowsSymbolFile Include="@(WindowsNativeFile -> '%(RootDir)%(Directory)PDB\%(Filename).pdb')" />
<!-- Crossgened files (on windows) have both a *.pdb and a *.ni.pdb symbol file. Include the *.ni.pdb file as well if it exists. -->
<WindowsSymbolFile Include="@(WindowsNativeFile -> '%(RootDir)%(Directory)PDB\%(Filename).ni.pdb')" />

<!--
Search for all xplat symbol file extensions on every xplat native binary. Some binaries have
Expand Down

0 comments on commit 3512bb3

Please sign in to comment.