Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Aspire Dashboard and .NET Monitor to Containers release notes #9380

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

lbussell
Copy link
Contributor

@lbussell lbussell commented Jul 3, 2024

Added:

  • .NET Monitor to the latest .NET 6 release notes
  • .NET Monitor and .NET Monitor Base to all .NET 8 release notes
  • .NET Monitor and .NET Monitor Base to all .NET 9 Preview release notes
  • .NET Aspire Dashboard to all .NET 8 release notes after it entered GA (Turned out to be just May '24)

There are no immediate plans to ship a .NET 9 version of the Aspire Dashboard so I left it off of .NET 9's release notes.

If there is a better place to submit this PR then LMK.

Fixes dotnet/dotnet-docker#5184

@MichaelSimons
Copy link
Member

Orthogonal but related, should the aspire-dashboard repo be included as well since it is now GA'd?

@lbussell
Copy link
Contributor Author

lbussell commented Jul 8, 2024

Orthogonal but related, should the aspire-dashboard repo be included as well since it is now GA'd?

It is included in https://github.com/dotnet/core/pull/9380/files#diff-b7d47f1656fcdef818b86605b119f047007bbab4670ca392304494c45c985930. Are you referring to something else?

@MichaelSimons
Copy link
Member

Orthogonal but related, should the aspire-dashboard repo be included as well since it is now GA'd?

It is included in https://github.com/dotnet/core/pull/9380/files#diff-b7d47f1656fcdef818b86605b119f047007bbab4670ca392304494c45c985930. Are you referring to something else?

That was my oversight. No further changes are necessary.

@lbussell
Copy link
Contributor Author

lbussell commented Jul 8, 2024

@rbhanda, @leecow, can we get these merged here, and also get these changes included for the next release as well?

@leecow
Copy link
Member

leecow commented Jul 8, 2024

I don't believe that part of the release notes is generated so your changes should persist release over release.

@rbhanda rbhanda merged commit 27c1e3b into dotnet:main Jul 8, 2024
2 of 3 checks passed
@rbhanda
Copy link
Contributor

rbhanda commented Jul 8, 2024

@rbhanda, @leecow, can we get these merged here, and also get these changes included for the next release as well?

Merged. These will also make to the release notes going forward starting with Jul releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add aspire-dashboard repo to .NET release notes
6 participants