Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List<CliToken> tokenList should be renamed to List<CliToken> tokens #2440

Open
PonchoPowers opened this issue Jun 7, 2024 · 0 comments
Open

List<CliToken> tokenList should be renamed to List<CliToken> tokens #2440

PonchoPowers opened this issue Jun 7, 2024 · 0 comments

Comments

@PonchoPowers
Copy link

There are a few mentions of tokenList left in Tokenizer.Tokenize and they should be renamed to remove the type "List" so that the naming conforms to the conventions of the .NET Framework.

Also, where (CliSymbol Symbol, CliTokenType TokenType)> tokens is used, the word tokens should be changed to validTokens to avoid any confusion between the list of valid tokens and the list of tokens being built up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PonchoPowers