Skip to content

Update SDK #48908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 24, 2023
Merged

Update SDK #48908

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2f76362
Update SDK
RussKie Jun 20, 2023
8b17dee
Fix trimming annotation error
SteveSandersonMS Jun 22, 2023
47f5966
Supress RID resolution warning
SteveSandersonMS Jun 22, 2023
3755745
Update SDK further to get fix https://github.com/dotnet/runtime/pull/…
SteveSandersonMS Jun 22, 2023
56d8310
Attempted further workaround
SteveSandersonMS Jun 22, 2023
db226bb
Revert attempted workaround that didn't work
SteveSandersonMS Jun 22, 2023
9db37bd
Disable RID check in templates with SQLite
captainsafia Jun 23, 2023
719fc18
Try different location for RID workaround
halter73 Jun 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Middleware/Spa/SpaProxy/src/SpaHostingStartup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public void Configure(IWebHostBuilder builder)
});

[UnconditionalSuppressMessageAttribute("Trimming", "IL2026", Justification = "Configuration object's public properties are preserved.")]
static void ConfigureOptions<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)] T>(IServiceCollection services, IConfigurationSection section)
static void ConfigureOptions<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.All)] T>(IServiceCollection services, IConfigurationSection section)
Copy link
Member

@SteveSandersonMS SteveSandersonMS Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upstream annotation (in Configure<TOptions>) now specifies DynamicallyAccessedMemberTypes.All, so we have to broaden the annotation here to match.

Copy link
Member

@halter73 halter73 Jun 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The weird thing is the underlying API hasn't change in the last 10 months.

https://github.com/dotnet/runtime/blob/dee36a1ea369517c1253dd560eabecc7ddcf987c/src/libraries/Microsoft.Extensions.Options.ConfigurationExtensions/src/OptionsConfigurationServiceCollectionExtensions.cs

Was there a linker or anlalyzer change?

Copy link
Member

@SteveSandersonMS SteveSandersonMS Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question

Copy link
Member

@eerhardt eerhardt Jun 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbomer @agocke @vitek-karas - any thoughts on what could have fixed this between 8.0.100-preview.6.23305.3 and 8.0.100-preview.7.23321.23? We must have had a bug here in the analyzer?

Copy link
Member

@vitek-karas vitek-karas Jun 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the configuration binder source generator? I seem to see something like the Configure call below to be handled by the source generated at least in some cases. So it's possible that it's effectively started to call a different overload than before? Just guessing.

Copy link
Member

@halter73 halter73 Jun 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

/home/vsts/work/1/s/src/Middleware/Spa/SpaProxy/src/SpaHostingStartup.cs(37,13): error IL2091: 'TOptions' generic argument does not satisfy 'DynamicallyAccessedMemberTypes.All' in 'Microsoft.Extensions.DependencyInjection.OptionsConfigurationServiceCollectionExtensions.Configure<TOptions>(IServiceCollection, IConfiguration)'. The generic parameter 'T' of 'ConfigureOptions<T>(IServiceCollection, IConfigurationSection)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to. [/home/vsts/work/1/s/src/Middleware/Spa/SpaProxy/src/Microsoft.AspNetCore.SpaProxy.csproj]
##[error]src/Middleware/Spa/SpaProxy/src/SpaHostingStartup.cs(37,13): error IL2091: (NETCORE_ENGINEERING_TELEMETRY=Build) 'TOptions' generic argument does not satisfy 'DynamicallyAccessedMemberTypes.All' in 'Microsoft.Extensions.DependencyInjection.OptionsConfigurationServiceCollectionExtensions.Configure<TOptions>(IServiceCollection, IConfiguration)'. The generic parameter 'T' of 'ConfigureOptions<T>(IServiceCollection, IConfigurationSection)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

The IL2091 error specifically references the call to Microsoft.Extensions.DependencyInjection.OptionsConfigurationServiceCollectionExtensions.Configure<TOptions>(IServiceCollection, IConfiguration), so I don't think the call is getting intercepted by the source generator.

where T : class
{
services.Configure<T>(section);
Expand Down