From c8c241c5ecba1989a8242d3019d865b1047edf57 Mon Sep 17 00:00:00 2001 From: Jeremy Koritzinsky Date: Wed, 11 Nov 2020 11:21:40 -0800 Subject: [PATCH 1/3] Remove usage of the Microsoft.NETCore.Internal package and replace with other non-shipping packages from dotnet/runtime to get a non-shipping version. --- eng/Version.Details.xml | 4 ++-- eng/Versions.props | 2 +- eng/targets/Helix.targets | 5 +++-- global.json | 4 ++-- .../App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj | 4 ++-- src/Installers/Windows/WindowsHostingBundle/Product.targets | 4 ++-- 6 files changed, 12 insertions(+), 11 deletions(-) diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml index 9aaa151e74c4..5e3f4610f372 100644 --- a/eng/Version.Details.xml +++ b/eng/Version.Details.xml @@ -298,11 +298,11 @@ https://github.com/dotnet/runtime 72b7d236ad634c2280c73499ebfc2b594995ec06 - + https://github.com/dotnet/runtime 72b7d236ad634c2280c73499ebfc2b594995ec06 - + https://github.com/dotnet/runtime 72b7d236ad634c2280c73499ebfc2b594995ec06 diff --git a/eng/Versions.props b/eng/Versions.props index 44bd5949b9ab..5609f86f1676 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -65,10 +65,10 @@ 6.0.0-alpha.1.20560.10 - 6.0.0-alpha.1.20560.10 6.0.0-alpha.1.20560.10 6.0.0-alpha.1.20560.10 6.0.0-alpha.1.20560.10 + 6.0.0-alpha.1.20560.10 6.0.0-alpha.1.20560.10 6.0.0-alpha.1.20560.10 6.0.0-alpha.1.20560.10 diff --git a/eng/targets/Helix.targets b/eng/targets/Helix.targets index e91b573dba29..b63b781d168f 100644 --- a/eng/targets/Helix.targets +++ b/eng/targets/Helix.targets @@ -161,9 +161,10 @@ - call runtests.cmd $(TargetFileName) $(NETCoreSdkVersion) $(MicrosoftNETCoreAppInternalPackageVersion) $(SharedFxVersion) $(_HelixFriendlyNameTargetQueue) $(TargetArchitecture) $(RunQuarantinedTests) $(DotnetEfPackageVersion) $(HelixTimeout) $(DotNetRuntimeSourceFeedKey) - ./runtests.sh $(TargetFileName) $(NETCoreSdkVersion) $(MicrosoftNETCoreAppInternalPackageVersion) $(SharedFxVersion) $(_HelixFriendlyNameTargetQueue) $(TargetArchitecture) $(RunQuarantinedTests) $(DotnetEfPackageVersion) $(HelixTimeout) $(DotNetRuntimeSourceFeedKey) + call runtests.cmd $(TargetFileName) $(NETCoreSdkVersion) $(MicrosoftNETCoreBrowserDebugHostTransportPackageVersion) $(SharedFxVersion) $(_HelixFriendlyNameTargetQueue) $(TargetArchitecture) $(RunQuarantinedTests) $(DotnetEfPackageVersion) $(HelixTimeout) $(DotNetRuntimeSourceFeedKey) + ./runtests.sh $(TargetFileName) $(NETCoreSdkVersion) $(MicrosoftNETCoreBrowserDebugHostTransportPackageVersion) $(SharedFxVersion) $(_HelixFriendlyNameTargetQueue) $(TargetArchitecture) $(RunQuarantinedTests) $(DotnetEfPackageVersion) $(HelixTimeout) $(DotNetRuntimeSourceFeedKey) $(HelixCommand) $(HelixTimeout) diff --git a/global.json b/global.json index 2526c387f8f0..7221a5ead8b4 100644 --- a/global.json +++ b/global.json @@ -7,10 +7,10 @@ "runtimes": { "dotnet/x64": [ "2.1.18", - "$(MicrosoftNETCoreAppInternalPackageVersion)" + "$(MicrosoftNETCoreBrowserDebugHostTransportPackageVersion)" ], "dotnet/x86": [ - "$(MicrosoftNETCoreAppInternalPackageVersion)" + "$(MicrosoftNETCoreBrowserDebugHostTransportPackageVersion)" ], "aspnetcore/x64": [ "3.1.4" diff --git a/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj b/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj index dd7368806f96..48a2b846efae 100644 --- a/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj +++ b/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj @@ -31,8 +31,8 @@ This package is an internal implementation of the .NET Core SDK and is not meant runtimes/$(RuntimeIdentifier)/native/ dotnet-runtime-$(MicrosoftNETCoreAppRuntimeVersion)-$(TargetRuntimeIdentifier)$(ArchiveExtension) - $(DotNetAssetRootUrl)Runtime/$(MicrosoftNETCoreAppInternalPackageVersion)/$(DotNetRuntimeArchiveFileName) - $(DotNetPrivateAssetRootUrl)Runtime/$(MicrosoftNETCoreAppInternalPackageVersion)/$(DotNetRuntimeArchiveFileName) + $(DotNetAssetRootUrl)Runtime/$(VSRedistCommonNetCoreSharedFrameworkx6460PackageVersion)/$(DotNetRuntimeArchiveFileName) + $(DotNetPrivateAssetRootUrl)Runtime/$(VSRedistCommonNetCoreSharedFrameworkx6460PackageVersion)/$(DotNetRuntimeArchiveFileName) $(BaseIntermediateOutputPath)$(DotNetRuntimeArchiveFileName) diff --git a/src/Installers/Windows/WindowsHostingBundle/Product.targets b/src/Installers/Windows/WindowsHostingBundle/Product.targets index bb09f9c65c6d..fe7610783e2f 100644 --- a/src/Installers/Windows/WindowsHostingBundle/Product.targets +++ b/src/Installers/Windows/WindowsHostingBundle/Product.targets @@ -28,10 +28,10 @@ - + dotnet-runtime-$(MicrosoftNETCoreAppRuntimeVersion)-win-x64.exe - + dotnet-runtime-$(MicrosoftNETCoreAppRuntimeVersion)-win-x86.exe From 5deff8607f9dd5dd3ce1e188aff164387732f39f Mon Sep 17 00:00:00 2001 From: Jeremy Koritzinsky Date: Wed, 11 Nov 2020 11:35:19 -0800 Subject: [PATCH 2/3] Use BrowserDebugHost as the only sentinel package. --- eng/Version.Details.xml | 4 ---- eng/Versions.props | 1 - .../App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj | 5 +++-- src/Installers/Windows/WindowsHostingBundle/Product.targets | 5 +++-- 4 files changed, 6 insertions(+), 9 deletions(-) diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml index 5e3f4610f372..b7abae2c3ffb 100644 --- a/eng/Version.Details.xml +++ b/eng/Version.Details.xml @@ -302,10 +302,6 @@ https://github.com/dotnet/runtime 72b7d236ad634c2280c73499ebfc2b594995ec06 - - https://github.com/dotnet/runtime - 72b7d236ad634c2280c73499ebfc2b594995ec06 - diff --git a/eng/Versions.props b/eng/Versions.props index 5609f86f1676..1f5abf52a4b8 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -68,7 +68,6 @@ 6.0.0-alpha.1.20560.10 6.0.0-alpha.1.20560.10 6.0.0-alpha.1.20560.10 - 6.0.0-alpha.1.20560.10 6.0.0-alpha.1.20560.10 6.0.0-alpha.1.20560.10 6.0.0-alpha.1.20560.10 diff --git a/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj b/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj index 48a2b846efae..09501244a161 100644 --- a/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj +++ b/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj @@ -30,9 +30,10 @@ This package is an internal implementation of the .NET Core SDK and is not meant runtimes/$(RuntimeIdentifier)/native/ + dotnet-runtime-$(MicrosoftNETCoreAppRuntimeVersion)-$(TargetRuntimeIdentifier)$(ArchiveExtension) - $(DotNetAssetRootUrl)Runtime/$(VSRedistCommonNetCoreSharedFrameworkx6460PackageVersion)/$(DotNetRuntimeArchiveFileName) - $(DotNetPrivateAssetRootUrl)Runtime/$(VSRedistCommonNetCoreSharedFrameworkx6460PackageVersion)/$(DotNetRuntimeArchiveFileName) + $(DotNetAssetRootUrl)Runtime/$(MicrosoftNETCoreBrowserDebugHostTransportPackageVersion)/$(DotNetRuntimeArchiveFileName) + $(DotNetPrivateAssetRootUrl)Runtime/$(MicrosoftNETCoreBrowserDebugHostTransportPackageVersion)/$(DotNetRuntimeArchiveFileName) $(BaseIntermediateOutputPath)$(DotNetRuntimeArchiveFileName) diff --git a/src/Installers/Windows/WindowsHostingBundle/Product.targets b/src/Installers/Windows/WindowsHostingBundle/Product.targets index fe7610783e2f..235d8f8488ce 100644 --- a/src/Installers/Windows/WindowsHostingBundle/Product.targets +++ b/src/Installers/Windows/WindowsHostingBundle/Product.targets @@ -27,11 +27,12 @@ $(DotNetPrivateAssetRootUrl)/ + - + dotnet-runtime-$(MicrosoftNETCoreAppRuntimeVersion)-win-x64.exe - + dotnet-runtime-$(MicrosoftNETCoreAppRuntimeVersion)-win-x86.exe From a1dc35943c25bb8ca07783c86ed7238772fd6afa Mon Sep 17 00:00:00 2001 From: Doug Bunting <6431421+dougbu@users.noreply.github.com> Date: Mon, 16 Nov 2020 10:53:19 -0800 Subject: [PATCH 3/3] Apply suggestions from code review - adjust version properties to align with 44c0e6651e38 / #27784 --- eng/targets/Helix.targets | 4 ++-- global.json | 4 ++-- .../App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj | 4 ++-- src/Installers/Windows/WindowsHostingBundle/Product.targets | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/eng/targets/Helix.targets b/eng/targets/Helix.targets index b63b781d168f..b37916800f30 100644 --- a/eng/targets/Helix.targets +++ b/eng/targets/Helix.targets @@ -163,8 +163,8 @@ SharedFxVersion because that's needed even when the targeting pack isn't building. Use the BrowserDebugHost transport package as a sentinel for the non-shipping version of the NETCoreApp shared framework. --> - call runtests.cmd $(TargetFileName) $(NETCoreSdkVersion) $(MicrosoftNETCoreBrowserDebugHostTransportPackageVersion) $(SharedFxVersion) $(_HelixFriendlyNameTargetQueue) $(TargetArchitecture) $(RunQuarantinedTests) $(DotnetEfPackageVersion) $(HelixTimeout) $(DotNetRuntimeSourceFeedKey) - ./runtests.sh $(TargetFileName) $(NETCoreSdkVersion) $(MicrosoftNETCoreBrowserDebugHostTransportPackageVersion) $(SharedFxVersion) $(_HelixFriendlyNameTargetQueue) $(TargetArchitecture) $(RunQuarantinedTests) $(DotnetEfPackageVersion) $(HelixTimeout) $(DotNetRuntimeSourceFeedKey) + call runtests.cmd $(TargetFileName) $(NETCoreSdkVersion) $(MicrosoftNETCoreBrowserDebugHostTransportVersion) $(SharedFxVersion) $(_HelixFriendlyNameTargetQueue) $(TargetArchitecture) $(RunQuarantinedTests) $(DotnetEfVersion) $(HelixTimeout) $(DotNetRuntimeSourceFeedKey) + ./runtests.sh $(TargetFileName) $(NETCoreSdkVersion) $(MicrosoftNETCoreBrowserDebugHostTransportVersion) $(SharedFxVersion) $(_HelixFriendlyNameTargetQueue) $(TargetArchitecture) $(RunQuarantinedTests) $(DotnetEfVersion) $(HelixTimeout) $(DotNetRuntimeSourceFeedKey) $(HelixCommand) $(HelixTimeout) diff --git a/global.json b/global.json index 7221a5ead8b4..38c6c34a0c38 100644 --- a/global.json +++ b/global.json @@ -7,10 +7,10 @@ "runtimes": { "dotnet/x64": [ "2.1.18", - "$(MicrosoftNETCoreBrowserDebugHostTransportPackageVersion)" + "$(MicrosoftNETCoreBrowserDebugHostTransportVersion)" ], "dotnet/x86": [ - "$(MicrosoftNETCoreBrowserDebugHostTransportPackageVersion)" + "$(MicrosoftNETCoreBrowserDebugHostTransportVersion)" ], "aspnetcore/x64": [ "3.1.4" diff --git a/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj b/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj index 09501244a161..34525207bc4c 100644 --- a/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj +++ b/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj @@ -32,8 +32,8 @@ This package is an internal implementation of the .NET Core SDK and is not meant dotnet-runtime-$(MicrosoftNETCoreAppRuntimeVersion)-$(TargetRuntimeIdentifier)$(ArchiveExtension) - $(DotNetAssetRootUrl)Runtime/$(MicrosoftNETCoreBrowserDebugHostTransportPackageVersion)/$(DotNetRuntimeArchiveFileName) - $(DotNetPrivateAssetRootUrl)Runtime/$(MicrosoftNETCoreBrowserDebugHostTransportPackageVersion)/$(DotNetRuntimeArchiveFileName) + $(DotNetAssetRootUrl)Runtime/$(MicrosoftNETCoreBrowserDebugHostTransportVersion)/$(DotNetRuntimeArchiveFileName) + $(DotNetPrivateAssetRootUrl)Runtime/$(MicrosoftNETCoreBrowserDebugHostTransportVersion)/$(DotNetRuntimeArchiveFileName) $(BaseIntermediateOutputPath)$(DotNetRuntimeArchiveFileName) diff --git a/src/Installers/Windows/WindowsHostingBundle/Product.targets b/src/Installers/Windows/WindowsHostingBundle/Product.targets index 235d8f8488ce..070507053fbc 100644 --- a/src/Installers/Windows/WindowsHostingBundle/Product.targets +++ b/src/Installers/Windows/WindowsHostingBundle/Product.targets @@ -29,10 +29,10 @@ - + dotnet-runtime-$(MicrosoftNETCoreAppRuntimeVersion)-win-x64.exe - + dotnet-runtime-$(MicrosoftNETCoreAppRuntimeVersion)-win-x86.exe