Skip to content

Switch to embedded PackageIcon #14346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wtgodbe wants to merge 1 commit into from
Closed

Switch to embedded PackageIcon #14346

wtgodbe wants to merge 1 commit into from

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Sep 23, 2019

Part of aspnet/AspNetCore-Internal#3146

Local build passes the smell test with these changes.

@wtgodbe wtgodbe requested a review from a team September 23, 2019 23:18
dougbu
dougbu reviewed Sep 24, 2019
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wtgodbe please let me know when the missing property is in the .nuspec files and you've confirmed the final packages

@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 24, 2019
@wtgodbe
Copy link
Member Author

wtgodbe commented Sep 24, 2019

Closing in favor of #14394

@wtgodbe wtgodbe closed this Sep 24, 2019
@wtgodbe wtgodbe deleted the embedded branch September 24, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS

1 more reviewer

@dougbu dougbu dougbu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wtgodbe @dougbu @Pilchie