Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that HttpSys and IIS TLS support isn't impacted by obsolete members on ITlsHandshakeFeature #59426

Open
1 task done
JamesNK opened this issue Dec 11, 2024 · 0 comments
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Milestone

Comments

@JamesNK
Copy link
Member

JamesNK commented Dec 11, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

Runtime obsoleted various properties and types used on SslStream: dotnet/runtime#100361. These properties are exposed in ASP.NET Core with ITlsHandshakeFeature. We have also made the properties obsolete in #59389. This was done as part of build ops and unstuck the build.

More time should be spent looking at this. An expert in HttpSys and IIS should investigate that TLS functionality isn't negatively impacted by obsoleting the properties.

One possible change is populating the NegotiatedCipherSuite property. HttpSys and IIS don't appear to set the new recommended property on the feature.

Expected Behavior

No response

Steps To Reproduce

No response

Exceptions (if any)

No response

.NET Version

No response

Anything else?

No response

@JamesNK JamesNK added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Dec 11, 2024
@adityamandaleeka adityamandaleeka added this to the 10.0-preview1 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

No branches or pull requests

2 participants