Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bucket size hints to histograms #53359

Closed
JamesNK opened this issue Jan 14, 2024 · 0 comments · Fixed by #56500
Closed

Add bucket size hints to histograms #53359

JamesNK opened this issue Jan 14, 2024 · 0 comments · Fixed by #56500
Assignees
@JamesNK
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Milestone
9.0-preview7

Comments

@JamesNK
Copy link
Member

JamesNK commented Jan 14, 2024

Histograms use buckets to efficiently store data. Good data requires good histogram bucket sizes, customized to an instrument. Hacks were required in .NET 8 to be in a good place here.

A feature to improve this in System.Diaganostics.Metrics is planned for .NET 9. We need to update our metrics to use the new API where appropriate and remove hacks.
@JamesNK JamesNK added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Jan 14, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
@JamesNK JamesNK mentioned this issue Jun 28, 2024
Merged
@JamesNK JamesNK self-assigned this Jun 30, 2024
@JamesNK JamesNK modified the milestones: .NET 9 Planning, 9.0-preview7 Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamesNK JamesNK

Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
9.0-preview7
Development

Successfully merging a pull request may close this issue.

Annotate histograms with bucket boundaries dotnet/aspnetcore
2 participants
@JamesNK @wtgodbe