Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch JSON serializer usage over to new source generator APIs #31877

Closed
CoffeeFlux opened this issue Apr 16, 2021 · 6 comments
Closed

Switch JSON serializer usage over to new source generator APIs #31877

CoffeeFlux opened this issue Apr 16, 2021 · 6 comments
Assignees
Labels
area-blazor Includes: Blazor, Razor Components enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-blazor-jsinterop This issue is related to JSInterop in Blazor Pillar: Technical Debt Priority:1 Work that is critical for the release, but we could probably ship without
Milestone

Comments

@CoffeeFlux
Copy link

Until this happens, the default Blazor template will have a size regression: dotnet/runtime#51311

New APIs: dotnet/runtime#45448 (comment)

Initial attempt: https://github.com/eerhardt/aspnetcore/commits/json-tmp

cc: @mkArtakMSFT @eerhardt @layomia

@pranavkm pranavkm added the area-blazor Includes: Blazor, Razor Components label Apr 16, 2021
@mkArtakMSFT mkArtakMSFT added the enhancement This issue represents an ask for new feature or an enhancement to an existing one label Apr 19, 2021
@mkArtakMSFT mkArtakMSFT added this to the Next sprint planning milestone Apr 19, 2021
@ghost
Copy link

ghost commented Apr 19, 2021

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. Because it's not immediately obvious that this is a bug in our framework, we would like to keep this around to collect more feedback, which can later help us determine the impact of it. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@ghost
Copy link

ghost commented Jul 20, 2021

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@TanayParikh TanayParikh modified the milestones: Backlog, .NET 7 Planning Oct 19, 2021
@ghost
Copy link

ghost commented Oct 21, 2021

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@ghost
Copy link

ghost commented Jan 3, 2024

Thanks for contacting us.

We're moving this issue to the .NET 9 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@mkArtakMSFT
Copy link
Member

@MackinnonBuck what is left here to be done?

@MackinnonBuck
Copy link
Member

As of #54956, we've started to use the STJ source generator during WebAssembly startup. This was a targeted change whose goal was to improve startup performance. We also scoped the changes to be limited to those that didn't require new public API.

In the future, we could revisit this area by creating new public APIs that enable customers to utilize the STJ source generator for JS interop, persistent component state, etc. We currently have #39839 and #40683 to track specific scenarios that could benefit from supporting the STJ source generator, and we can open new issues in the future for additional scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-blazor-jsinterop This issue is related to JSInterop in Blazor Pillar: Technical Debt Priority:1 Work that is critical for the release, but we could probably ship without
Projects
None yet
Development

No branches or pull requests

6 participants