Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance difference: mvc, mvc #31703

Closed
pr-benchmarks bot opened this issue Apr 12, 2021 · 5 comments · Fixed by dotnet/runtime#51163
Closed

Performance difference: mvc, mvc #31703

pr-benchmarks bot opened this issue Apr 12, 2021 · 5 comments · Fixed by dotnet/runtime#51163
Assignees
@davidfowl
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Perf perf-regression
Milestone
6.0-preview4

Comments

@pr-benchmarks
Copy link

pr-benchmarks bot commented Apr 12, 2021 •
edited
Loading

A performance regression has been detected for the following scenarios:

Scenario Environment Date Old RPS New RPS Change Deviation StDev
mvc [Fixed] Plaintext Mvc aspnet-citrine-lin 04/10/2021 20:05:42 2,056,959 1,956,553 -4.88 % (-100,406) 👎 -3.57 σ 28,112.93
mvc [Fixed] Plaintext Mvc aspnet-citrine-amd 04/10/2021 20:20:38 3,949,675 2,025,105 -48.73 % (-1,924,570) 👎 -10.84 σ 177,589.45

Changes:

Runtime Previous Version Current Version Diff
ASP.NET 6.0.0-preview.4.21209.12 6.0.0-preview.4.21210.2 985ef47...81936a7
CLR 6.0.0-preview.4.21209.14 6.0.0-preview.4.21210.4 dotnet/runtime@403ae35...9b647fe
SDK 6.0.100-preview.4.21209.4 6.0.100-preview.4.21210.1 n/a

@sebastienros
@pr-benchmarks pr-benchmarks bot added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Perf perf-regression labels Apr 12, 2021
@davidfowl
Copy link
Member

😮

@davidfowl davidfowl mentioned this issue Apr 13, 2021
Merged
@davidfowl davidfowl self-assigned this Apr 13, 2021
@davidfowl davidfowl added this to the 6.0-preview4 milestone Apr 14, 2021
@halter73
Copy link
Member

Interesting that diff range didn't include dotnet/runtime#50463.

@halter73
Copy link
Member

@BrennanConroy figured it out. It's because we don't consume DI from the shared runtime and had to wait for the arcade update. I wonder if the bot can be updated to track this.

@sebastienros
Copy link
Member

We explained it on Monday, but you preferred to join a different meeting, your loss ;) I implemented custom package references in crank since then, and enabled "latest" extensions (like runtime) in most benchmarks. So now the runtime diff will actually include extensions, even if arcade is slow on aspnet.

@davidfowl
Copy link
Member

@sebastienros I should have let the bot closed this huh.

@ghost ghost locked as resolved and limited conversation to collaborators May 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@davidfowl davidfowl

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Perf perf-regression
Projects
None yet
Milestone
6.0-preview4
Development

Successfully merging a pull request may close this issue.

Removed scope pooling and added diagnostics dotnet/runtime
3 participants
@halter73 @davidfowl @sebastienros