Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spanify DataProtection code #30013

Closed
HaoK opened this issue Feb 8, 2021 · 3 comments
Closed

Spanify DataProtection code #30013

HaoK opened this issue Feb 8, 2021 · 3 comments
Assignees
@HaoK
Labels
affected-medium This issue impacts approximately half of our customers area-dataprotection Includes: DataProtection Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one ✔️ Resolution: Duplicate Resolved as a duplicate of another issue Perf severity-major This label is used by an internal tool Status: Resolved
Milestone
6.0-preview3

Comments

@HaoK
Copy link
Member

HaoK commented Feb 8, 2021

Follow up to #29814

@GrabYourPitchforks mentioned that there's a bunch pre span code that would benefit from updating

cc @blowdart @mkArtakMSFT putting this in preview 2 for now
@HaoK HaoK added the area-dataprotection Includes: DataProtection label Feb 8, 2021
@HaoK HaoK added this to the 6.0-preview2 milestone Feb 8, 2021
@HaoK HaoK self-assigned this Feb 8, 2021
@HaoK HaoK added affected-all This issue impacts all the customers enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-major This label is used by an internal tool labels Feb 18, 2021 — with ASP.NET Core Issue Ranking
@HaoK HaoK added affected-medium This issue impacts approximately half of our customers Perf and removed affected-all This issue impacts all the customers labels Feb 18, 2021
@HaoK HaoK mentioned this issue Feb 23, 2021
Closed
@HaoK
Copy link
Member Author

HaoK commented Feb 24, 2021

Also address follow up to #29814 (comment) as part of this issue, and the reg ex issue linked

@HaoK HaoK added the Working label Feb 24, 2021
@HaoK HaoK mentioned this issue Feb 25, 2021
Closed
@HaoK
Copy link
Member Author

HaoK commented Mar 15, 2021

More span/new apis in #30941 (comment)

@HaoK
Copy link
Member Author

HaoK commented Mar 15, 2021

Will handle any remaning minor span cleanup as part of the PR switching to framework version of PDKDF in #30941 closing as dupe

@HaoK HaoK closed this as completed Mar 15, 2021
@ghost ghost added Done This issue has been fixed and removed Working labels Mar 15, 2021
@HaoK HaoK added the ✔️ Resolution: Duplicate Resolved as a duplicate of another issue label Mar 15, 2021
@ghost ghost added the Status: Resolved label Mar 15, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HaoK HaoK

Labels
affected-medium This issue impacts approximately half of our customers area-dataprotection Includes: DataProtection Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one ✔️ Resolution: Duplicate Resolved as a duplicate of another issue Perf severity-major This label is used by an internal tool Status: Resolved
Projects
None yet
Milestone
6.0-preview3
Development

Successfully merging a pull request may close this issue.

WIP DataProtection spanification dotnet/aspnetcore
2 participants
@HaoK @mkArtakMSFT