Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script command to sql-cache tool #24635

Closed
glatzert opened this issue Aug 3, 2020 · 11 comments · Fixed by #30398
Closed

Add script command to sql-cache tool #24635

glatzert opened this issue Aug 3, 2020 · 11 comments · Fixed by #30398
Labels
affected-very-few This issue impacts very few customers area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one help wanted Up for grabs. We would accept a PR to help resolve this issue severity-nice-to-have This label is used by an internal tool
Milestone

Comments

@glatzert
Copy link

glatzert commented Aug 3, 2020

Is your feature request related to a problem? Please describe.

I am trying to create the tables for distributed sql cache via the dotnet tool "sql-cache".
This works well, as long a I am developing and have full database access, but it's not working for scenarios, where I lack of access rights.

Describe the solution you'd like

Add dotnet sql-cache script, so the neccessary commands are written to the stdout and can easily be copied to an textfile.

@mkArtakMSFT
Copy link
Member

@ajcvickers who is best positioned to handle this?

@ajcvickers
Copy link
Member

@mkArtakMSFT Ownership of the SQL caching tool was transferred to @ericstj's team. I'll move this to dotnet/runtime.

@ajcvickers ajcvickers transferred this issue from dotnet/aspnetcore Aug 6, 2020
@Dotnet-GitSync-Bot
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ericstj
Copy link
Member

ericstj commented Aug 6, 2020

@ajcvickers we don't own this tool. I believe the tool still lives here and is owned and maintained by @Pilchie s team: https://github.com/dotnet/aspnetcore/tree/master/src/Tools/dotnet-sql-cache

@ericstj ericstj transferred this issue from dotnet/runtime Aug 6, 2020
@ajcvickers
Copy link
Member

@mkArtakMSFT @Pilchie I thought this was part of Caching.SqlServer, but apparently it is not. It's not an EF thing, so I'm out of ideas.

@mkArtakMSFT
Copy link
Member

@Tratcher, @pranavkm, @javiercn do you happen to know who owns this tool in our team?

@javiercn
Copy link
Member

javiercn commented Aug 7, 2020

@JunTaoLuo maybe?

@Pilchie Pilchie added the area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI label Aug 7, 2020
@pranavkm pranavkm added the enhancement This issue represents an ask for new feature or an enhancement to an existing one label Aug 13, 2020
@pranavkm pranavkm added this to the Backlog milestone Aug 13, 2020
@ghost
Copy link

ghost commented Aug 13, 2020

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@glatzert
Copy link
Author

Btw, if you'd mark it up-for-grabs, I'd provide an implementation for
a) the script, which would be executed on SQL Server
b) an alternate script, which would create Statements for a memory optimized table

@Pilchie
Copy link
Member

Pilchie commented Aug 25, 2020

We don't (yet), have an up-for-grabs label, but I don't think we'd be against a contribution here. It's quite late for the .NET 5 release, so it's likely something that would end up in .NET 6 though.

@Tratcher
Copy link
Member

It's called help wanted in this repo. We also have good first issue for easier items.

@Tratcher Tratcher added the help wanted Up for grabs. We would accept a PR to help resolve this issue label Aug 25, 2020
@jkotalik jkotalik added affected-very-few This issue impacts very few customers severity-nice-to-have This label is used by an internal tool labels Nov 9, 2020 — with ASP.NET Core Issue Ranking
@mkArtakMSFT mkArtakMSFT added the Done This issue has been fixed label Mar 25, 2021
@mkArtakMSFT mkArtakMSFT linked a pull request Mar 25, 2021 that will close this issue
4 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Apr 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affected-very-few This issue impacts very few customers area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one help wanted Up for grabs. We would accept a PR to help resolve this issue severity-nice-to-have This label is used by an internal tool
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants