Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up what notifications are shown when user opens Blazor project in VS Code #23832

Closed
rynowak opened this issue Jul 10, 2020 · 7 comments
Closed
Assignees
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Milestone

Comments

@rynowak
Copy link
Member

rynowak commented Jul 10, 2020

Describe the bug

VS Code is showing me this notification many times after opening a repo.

image

To Reproduce

Unfortunately I cannot provide access to the repo. I opened VS code in the root of a git repository containing a bunch of .NET projects, and one of them is Blazor WASM.

I'd really prefer to see this when I try to launch/debug a Blazor WASM project or not at all. VS Code already has too much notification spam.

Further technical details

  • On macOS
  • C# extension 1.22.1
@NTaylorMullen
Copy link
Contributor

@rynowak I assume you don't want to setup the additional steps for Blazor Wasm debugging right? Also, this only pops up once upon opening VSCode right? or are you saying that it pops up repeatedly/many times in the same session?

@captainsafia what do you think about adding a "snooze"/ don't bother me anymore option that's cached?

@captainsafia
Copy link
Member

I believe this kind thing should only happen when you open VS Code. This message pops up when the O# extension does workspace discovery to determine what kinds of .NET projects you have (ref).

We can implement some "show this only once for this VS Code instance" logic on the O# extension to resolve this issue.

@rynowak
Copy link
Member Author

rynowak commented Jul 14, 2020

assume you don't want to setup the additional steps for Blazor Wasm debugging right?

I did not do this, because I wasn't working with the Blazor project. I believe this repo has a Blazor WASM project that was created using one of the pre-releases, and some corresponding tasks.json stuff.

Also, this only pops up once upon opening VSCode right? or are you saying that it pops up repeatedly/many times in the same session?

VS Code is showing me this notification many times after opening a repo.

The notification kept coming back after I dismissed it, for a couple of minutes.

@captainsafia
Copy link
Member

I just ran into this will working on the aspnetcore repo.

I had src/Components open for about an hour when the prompt popped up. Based on the logs, the O# extension was analyzing the workspace at the same time so that might be a breadcrumb for this issue.

@captainsafia
Copy link
Member

Per the mentioned issue above, now that we no longer require users to have the nightly JS debug extension, we can actually get rid of this additional setup warning all togehter.

@captainsafia captainsafia changed the title VS Code **REALLY** wants me to know about the additional setup needed for debugging Blazor WASM applications Clean up what notifications are shown when user opens Blazor project in VS Code Jul 30, 2020
@captainsafia
Copy link
Member

Commandeering this issue to address all notification related problems in VS Code:

  • Need to remove the "additional setup" notification
  • Need to make sure the required assets prompt is displayed

@mkArtakMSFT Can we track this for RC1? Should be low-cost.

@danroth27 danroth27 added bug This issue describes a behavior which is not expected - a bug. and removed investigate labels Aug 11, 2020
@captainsafia captainsafia self-assigned this Aug 24, 2020
@mkArtakMSFT mkArtakMSFT modified the milestones: 5.0.0-rc1, 5.0.0-rc2 Aug 24, 2020
@captainsafia
Copy link
Member

A fix for this has been merged into the C# extension.

@ghost ghost added Done This issue has been fixed and removed Working labels Aug 26, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Sep 25, 2020
@ghost ghost unlocked this conversation Oct 9, 2021
@allisonchou allisonchou added area-blazor Includes: Blazor, Razor Components and removed [obsolete] area-razor.tooling labels Oct 9, 2021
@dotnet dotnet locked as resolved and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Projects
None yet
Development

No branches or pull requests

7 participants