Add support for RouteHandlerInvocationContext<> overloads (#41406)

* Add support for RouteHandlerInvocationContext<> overloads

* Address feedback from review

* Address feedback from API review

* Rename RouteHandlerInvocationContextBase per API review

* Address more feedback from review

* Address more feedack

Author: captainsafia

src/Http/Http.Abstractions/src/DefaultRouteHandlerInvocationContext.cs

@@ -0,0 +1,34 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+namespace Microsoft.AspNetCore.Http;
+
+/// <summary>
+/// Provides a default implementation for wrapping the <see cref="HttpContext"/> and parameters
+/// provided to a route handler.
+/// </summary>
+public sealed class DefaultRouteHandlerInvocationContext : RouteHandlerInvocationContext
+{
+    /// <summary>
+    /// Creates a new instance of the <see cref="DefaultRouteHandlerInvocationContext"/> for a given request.
+    /// </summary>
+    /// <param name="httpContext">The <see cref="HttpContext"/> associated with the current request.</param>
+    /// <param name="arguments">A list of parameters provided in the current request.</param>
+    public DefaultRouteHandlerInvocationContext(HttpContext httpContext, params object[] arguments)
+    {
+        HttpContext = httpContext;
+        Arguments = arguments;
+    }
+
+    /// <inheritdoc />
+    public override HttpContext HttpContext { get; }
+
+    /// <inheritdoc />
+    public override IList<object?> Arguments { get; }
+
+    /// <inheritdoc />
+    public override T GetArgument<T>(int index)
+    {
+        return (T)Arguments[index]!;
+    }
+}

src/Http/Http.Abstractions/src/Microsoft.AspNetCore.Http.Abstractions.csproj

@@ -30,6 +30,26 @@ Microsoft.AspNetCore.Http.HttpResponse</Description>
 
   <ItemGroup>
     <InternalsVisibleTo Include="Microsoft.AspNetCore.Http.Abstractions.Microbenchmarks" />
+    <InternalsVisibleTo Include="Microsoft.AspNetCore.Http.Extensions" />
+  </ItemGroup>
+
+  <ItemGroup>
+    <None Update="RouteHandlerInvocationContextOfT.Generated.tt">
+      <Generator>TextTemplatingFileGenerator</Generator>
+      <LastGenOutput>RouteHandlerInvocationContextOfT.Generated.cs</LastGenOutput>
+    </None>
+  </ItemGroup>
+
+  <ItemGroup>
+    <Service Include="{508349b6-6b84-4df5-91f0-309beebad82d}" />
+  </ItemGroup>
+
+  <ItemGroup>
+    <Compile Update="RouteHandlerInvocationContextOfT.Generated.cs">
+      <DesignTime>True</DesignTime>
+      <AutoGen>True</AutoGen>
+      <DependentUpon>RouteHandlerInvocationContextOfT.Generated.tt</DependentUpon>
+    </Compile>
   </ItemGroup>
 
 </Project>

src/Http/Http.Abstractions/src/PublicAPI.Unshipped.txt

@@ -3,6 +3,8 @@
 *REMOVED*Microsoft.AspNetCore.Http.EndpointMetadataCollection.Enumerator.Current.get -> object?
 Microsoft.AspNetCore.Builder.EndpointBuilder.ServiceProvider.get -> System.IServiceProvider?
 Microsoft.AspNetCore.Builder.EndpointBuilder.ServiceProvider.set -> void
+Microsoft.AspNetCore.Http.DefaultRouteHandlerInvocationContext
+Microsoft.AspNetCore.Http.DefaultRouteHandlerInvocationContext.DefaultRouteHandlerInvocationContext(Microsoft.AspNetCore.Http.HttpContext! httpContext, params object![]! arguments) -> void
 Microsoft.AspNetCore.Http.EndpointMetadataCollection.Enumerator.Current.get -> object!
 Microsoft.AspNetCore.Http.EndpointMetadataCollection.GetRequiredMetadata<T>() -> T!
 Microsoft.AspNetCore.Http.IRouteHandlerFilter.InvokeAsync(Microsoft.AspNetCore.Http.RouteHandlerInvocationContext! context, Microsoft.AspNetCore.Http.RouteHandlerFilterDelegate! next) -> System.Threading.Tasks.ValueTask<object?>
@@ -14,9 +16,7 @@ Microsoft.AspNetCore.Http.RouteHandlerContext.MethodInfo.get -> System.Reflectio
 Microsoft.AspNetCore.Http.RouteHandlerContext.RouteHandlerContext(System.Reflection.MethodInfo! methodInfo, Microsoft.AspNetCore.Http.EndpointMetadataCollection! endpointMetadata) -> void
 Microsoft.AspNetCore.Http.RouteHandlerFilterDelegate
 Microsoft.AspNetCore.Http.RouteHandlerInvocationContext
-Microsoft.AspNetCore.Http.RouteHandlerInvocationContext.HttpContext.get -> Microsoft.AspNetCore.Http.HttpContext!
-Microsoft.AspNetCore.Http.RouteHandlerInvocationContext.Parameters.get -> System.Collections.Generic.IList<object?>!
-Microsoft.AspNetCore.Http.RouteHandlerInvocationContext.RouteHandlerInvocationContext(Microsoft.AspNetCore.Http.HttpContext! httpContext, params object![]! parameters) -> void
+Microsoft.AspNetCore.Http.RouteHandlerInvocationContext.RouteHandlerInvocationContext() -> void
 Microsoft.AspNetCore.Routing.RouteValueDictionary.RouteValueDictionary(Microsoft.AspNetCore.Routing.RouteValueDictionary? dictionary) -> void
 Microsoft.AspNetCore.Routing.RouteValueDictionary.RouteValueDictionary(System.Collections.Generic.IEnumerable<System.Collections.Generic.KeyValuePair<string!, object?>>? values) -> void
 Microsoft.AspNetCore.Routing.RouteValueDictionary.RouteValueDictionary(System.Collections.Generic.IEnumerable<System.Collections.Generic.KeyValuePair<string!, string?>>? values) -> void
@@ -27,3 +27,9 @@ Microsoft.AspNetCore.Http.Metadata.IEndpointDescriptionMetadata
 Microsoft.AspNetCore.Http.Metadata.IEndpointDescriptionMetadata.Description.get -> string!
 Microsoft.AspNetCore.Http.Metadata.IEndpointSummaryMetadata
 Microsoft.AspNetCore.Http.Metadata.IEndpointSummaryMetadata.Summary.get -> string!
+abstract Microsoft.AspNetCore.Http.RouteHandlerInvocationContext.Arguments.get -> System.Collections.Generic.IList<object?>!
+abstract Microsoft.AspNetCore.Http.RouteHandlerInvocationContext.GetArgument<T>(int index) -> T
+abstract Microsoft.AspNetCore.Http.RouteHandlerInvocationContext.HttpContext.get -> Microsoft.AspNetCore.Http.HttpContext!
+override Microsoft.AspNetCore.Http.DefaultRouteHandlerInvocationContext.Arguments.get -> System.Collections.Generic.IList<object?>!
+override Microsoft.AspNetCore.Http.DefaultRouteHandlerInvocationContext.GetArgument<T>(int index) -> T
+override Microsoft.AspNetCore.Http.DefaultRouteHandlerInvocationContext.HttpContext.get -> Microsoft.AspNetCore.Http.HttpContext!

src/Http/Http.Abstractions/src/RouteHandlerInvocationContext.cs

@@ -4,32 +4,29 @@
 namespace Microsoft.AspNetCore.Http;
 
 /// <summary>
-/// Provides an abstraction for wrapping the <see cref="HttpContext"/> and parameters
+/// Provides an abstraction for wrapping the <see cref="HttpContext"/> and arguments
 /// provided to a route handler.
 /// </summary>
-public sealed class RouteHandlerInvocationContext
+public abstract class RouteHandlerInvocationContext
 {
-    /// <summary>
-    /// Creates a new instance of the <see cref="RouteHandlerInvocationContext"/> for a given request.
-    /// </summary>
-    /// <param name="httpContext">The <see cref="HttpContext"/> associated with the current request.</param>
-    /// <param name="parameters">A list of parameters provided in the current request.</param>
-    public RouteHandlerInvocationContext(HttpContext httpContext, params object[] parameters)
-    {
-        HttpContext = httpContext;
-        Parameters = parameters;
-    }
-
     /// <summary>
     /// The <see cref="HttpContext"/> associated with the current request being processed by the filter.
     /// </summary>
-    public HttpContext HttpContext { get; }
+    public abstract HttpContext HttpContext { get; }
 
     /// <summary>
-    /// A list of parameters provided in the current request to the filter.
+    /// A list of arguments provided in the current request to the filter.
     /// <remarks>
-    /// This list is not read-only to permit modifying of existing parameters by filters.
+    /// This list is not read-only to permit modifying of existing arguments by filters.
     /// </remarks>
     /// </summary>
-    public IList<object?> Parameters { get; }
+    public abstract IList<object?> Arguments { get; }
+
+    /// <summary>
+    /// Retrieve the argument given its position in the argument list.
+    /// </summary>
+    /// <typeparam name="T">The <see cref="Type"/> of the resolved argument.</typeparam>
+    /// <param name="index">An integer representing the position of the argument in the argument list.</param>
+    /// <returns>The argument at a given <paramref name="index"/>.</returns>
+    public abstract T GetArgument<T>(int index);
 }