From 32dc633a115b942eac7279486bf2def2e87510cd Mon Sep 17 00:00:00 2001 From: Dan Moseley Date: Mon, 19 May 2025 18:32:01 -0600 Subject: [PATCH 1/5] copilot setup steps --- .github/workflows/copilot-setup-steps.yml | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 .github/workflows/copilot-setup-steps.yml diff --git a/.github/workflows/copilot-setup-steps.yml b/.github/workflows/copilot-setup-steps.yml new file mode 100644 index 00000000000..b6b4a5dc432 --- /dev/null +++ b/.github/workflows/copilot-setup-steps.yml @@ -0,0 +1,23 @@ +name: "Copilot Setup Steps" + +# Allow testing of the setup steps from your repository's "Actions" tab. +on: workflow_dispatch + +jobs: + # The job MUST be called `copilot-setup-steps` or it will not be picked up by Copilot. + copilot-setup-steps: + runs-on: ubuntu-latest + + # Set the permissions to the lowest permissions possible needed for your steps. + # Copilot will be given its own token for its operations. + permissions: + # If you want to clone the repository as part of your setup steps, for example to install dependencies, you'll need the `contents: read` permission. If you don't clone the repository in your setup steps, Copilot will do this for you automatically after the steps complete. + contents: read + + # You can define any steps you want, and they will run before the agent starts. + # If you do not check out your code, Copilot will do this for you. + steps: + - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 + + - name: Build solution + run: ./build.sh From 8f0e5d3408f11efa225de12bd4353bfd8390b210 Mon Sep 17 00:00:00 2001 From: Dan Moseley Date: Mon, 19 May 2025 18:35:27 -0600 Subject: [PATCH 2/5] more --- .github/workflows/copilot-setup-steps.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/copilot-setup-steps.yml b/.github/workflows/copilot-setup-steps.yml index b6b4a5dc432..30a895a2d98 100644 --- a/.github/workflows/copilot-setup-steps.yml +++ b/.github/workflows/copilot-setup-steps.yml @@ -8,10 +8,7 @@ jobs: copilot-setup-steps: runs-on: ubuntu-latest - # Set the permissions to the lowest permissions possible needed for your steps. - # Copilot will be given its own token for its operations. permissions: - # If you want to clone the repository as part of your setup steps, for example to install dependencies, you'll need the `contents: read` permission. If you don't clone the repository in your setup steps, Copilot will do this for you automatically after the steps complete. contents: read # You can define any steps you want, and they will run before the agent starts. From 4d497755078c45c3168aad32785ebd6866e53527 Mon Sep 17 00:00:00 2001 From: Dan Moseley Date: Mon, 19 May 2025 18:40:12 -0600 Subject: [PATCH 3/5] prepare for helix --- .github/workflows/copilot-setup-steps.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/copilot-setup-steps.yml b/.github/workflows/copilot-setup-steps.yml index 30a895a2d98..f6578dc6c90 100644 --- a/.github/workflows/copilot-setup-steps.yml +++ b/.github/workflows/copilot-setup-steps.yml @@ -16,5 +16,6 @@ jobs: steps: - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 + # Include PrepareForHelix to maximise what is downloaded here - name: Build solution - run: ./build.sh + run: ./build.sh /p:PrepareForHelix=true From 8171e49c22b67d85feb697ade4f47eec2b7a7860 Mon Sep 17 00:00:00 2001 From: Dan Moseley Date: Mon, 19 May 2025 18:47:51 -0600 Subject: [PATCH 4/5] update instructions --- .github/copilot-instructions.md | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md index 259dfb1fd93..00d6985297b 100644 --- a/.github/copilot-instructions.md +++ b/.github/copilot-instructions.md @@ -1,12 +1,10 @@ # Instructions for GitHub and VisualStudio Copilot ### https://github.blog/changelog/2025-01-21-custom-repository-instructions-are-now-available-for-copilot-on-github-com-public-preview/ - ## General * Make only high confidence suggestions when reviewing code changes. * Always use the latest version C#, currently C# 13 features. -* Files must have CRLF line endings. ## Formatting @@ -23,11 +21,15 @@ * Always use `is null` or `is not null` instead of `== null` or `!= null`. * Trust the C# null annotations and don't add null checks when the type system says a value cannot be null. - ### Testing * We use xUnit SDK v3 with Microsoft.Testing.Platform (https://learn.microsoft.com/dotnet/core/testing/microsoft-testing-platform-intro) * Do not emit "Act", "Arrange" or "Assert" comments. -* We do not use any mocking framework at the moment. Use NSubstitute, if necessary. Never use Moq. -* Use "snake_case" for test method names but keep the original method under test intact. - For example: when adding a test for methond "MethondToTest" instead of "MethondToTest_ShouldReturnSummarisedIssues" use "MethondToTest_should_return_summarised_issues". +* We do not use any mocking framework at the moment. +* Copy existing style in nearby files for test method names and capitalization. + +## Running tests + +(1) Build from the root with `build.sh`. +(2) If that produces errors, fix those errors and build again. Repeat until the build is successful. +(3) To then run tests, use a command similar to this `dotnet test tests/Aspire.Seq.Tests/Aspire.Seq.Tests.csproj` (using the path to whatever projects are applicable to the change). \ No newline at end of file From f923221b09e48db9ea09b7c236e01a92333ec425 Mon Sep 17 00:00:00 2001 From: Dan Moseley Date: Mon, 19 May 2025 18:54:44 -0600 Subject: [PATCH 5/5] more: --- .github/copilot-instructions.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md index 00d6985297b..fcda63147a4 100644 --- a/.github/copilot-instructions.md +++ b/.github/copilot-instructions.md @@ -5,6 +5,7 @@ * Make only high confidence suggestions when reviewing code changes. * Always use the latest version C#, currently C# 13 features. +* Never change global.json unless explicitly asked to. ## Formatting