From 5932bcb3c583c30f90a71a5fa752200a29fccfeb Mon Sep 17 00:00:00 2001 From: Adam Ratzman Date: Wed, 14 May 2025 16:53:48 -0300 Subject: [PATCH] Increase retry time in AppBar_Change_Theme_ReloadPage --- .../Integration/Playwright/AppBarTests.cs | 3 ++- tests/Shared/AsyncTestHelpers.cs | 12 +++++------- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/tests/Aspire.Dashboard.Tests/Integration/Playwright/AppBarTests.cs b/tests/Aspire.Dashboard.Tests/Integration/Playwright/AppBarTests.cs index b6e8bf2c782..41d1ee201b1 100644 --- a/tests/Aspire.Dashboard.Tests/Integration/Playwright/AppBarTests.cs +++ b/tests/Aspire.Dashboard.Tests/Integration/Playwright/AppBarTests.cs @@ -104,7 +104,8 @@ await Assertions await AsyncTestHelpers.AssertIsTrueRetryAsync( async () => await checkbox.IsCheckedAsync(), - "Checkbox isn't immediately checked."); + "Checkbox isn't immediately checked.", + retries: 15 /* this seems to take a very long time to run, so needs a long timeout */); } }); } diff --git a/tests/Shared/AsyncTestHelpers.cs b/tests/Shared/AsyncTestHelpers.cs index d3941eebd2b..23ea32a9cde 100644 --- a/tests/Shared/AsyncTestHelpers.cs +++ b/tests/Shared/AsyncTestHelpers.cs @@ -195,18 +195,16 @@ private static string CreateMessage(TimeSpan timeout, string filePath, int lineN ? $"The operation timed out after reaching the limit of {timeout.TotalMilliseconds}ms." : $"The operation at {filePath}:{lineNumber} timed out after reaching the limit of {timeout.TotalMilliseconds}ms."; - public static Task AssertIsTrueRetryAsync(Func assert, string message, ILogger? logger = null) + public static Task AssertIsTrueRetryAsync(Func assert, string message, ILogger? logger = null, int retries = 10) { - return AssertIsTrueRetryAsync(() => Task.FromResult(assert()), message, logger); + return AssertIsTrueRetryAsync(() => Task.FromResult(assert()), message, logger, retries); } - public static async Task AssertIsTrueRetryAsync(Func> assert, string message, ILogger? logger = null) + public static async Task AssertIsTrueRetryAsync(Func> assert, string message, ILogger? logger = null, int retries = 10) { - const int Retries = 10; - logger?.LogInformation("Start: " + message); - for (var i = 0; i < Retries; i++) + for (var i = 0; i < retries; i++) { if (i > 0) { @@ -220,6 +218,6 @@ public static async Task AssertIsTrueRetryAsync(Func> assert, string } } - throw new InvalidOperationException($"Assert failed after {Retries} retries: {message}"); + throw new InvalidOperationException($"Assert failed after {retries} retries: {message}"); } }