Add Functions host support to AzureTableStorageResource #7961
+24
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
PR Overview
This PR adds support for Azure Functions configuration for the Azure Table Storage resource by implementing the IResourceWithAzureFunctionsConfig interface. Key changes include:
- Updating AzureTableStorageResource to implement IResourceWithAzureFunctionsConfig.
- Adding an explicit implementation of ApplyAzureFunctionsConfiguration in AzureTableStorageResource.
- Introducing Tables-specific connection key prefixes and settings in AzureStorageResource.
Reviewed Changes
| File | Description |
|---|---|
| src/Aspire.Hosting.Azure.Storage/AzureTableStorageResource.cs | Added IResourceWithAzureFunctionsConfig implementation to provide Azure Functions configuration support for table storage. |
| src/Aspire.Hosting.Azure.Storage/AzureStorageResource.cs | Introduced TablesConnectionKeyPrefix constant and updated ApplyAzureFunctionsConfiguration to include table-related settings. |
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
davidfowl
approved these changes
Mar 8, 2025
Member
|
No test updates? |
Member
Author
Our test coverage for these has usually been E2E tests with a trigger. We don't have unit tests for this behavior. I can add some in a follow-up PR. |
1 task
github-actions
bot
added
the
area-integrations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure Tables are a dependency for Durable Functions in deployments. We need to implement the
IResourceWithAzureFunctionsConfigon the AzureStorageTableResource in order to support this.