-
Notifications
You must be signed in to change notification settings - Fork 715
WaitFor for Elasticsearch #5725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Looks good to me (based on our current pattern). |
|
The timeout in the test might be too low. I don't know how long elastic search takes to boot but its notoriously slow and unreliable from our other tests? |
|
cc @radical note the changes |
| <_DefaultWorkItems TimeoutMs="900000" /> | ||
|
|
||
| <_DefaultWorkItems Condition="'%(FileName)' == 'Aspire.Hosting.Elasticsearch.Tests'" TimeoutMs="1200000" /> | ||
| <_DefaultWorkItems Condition="'%(FileName)' == 'Aspire.Hosting.Elasticsearch.Tests'" TimeoutMs="3600000" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really an hour? We are going to wait an hour for these tests? Isn't that just going to make us wait longer when the thing isn't responsive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will become a problem whenever helix is backed up. The total timeout for the whole job is 90mins, so this will definitely timeout. Do we need to break this up?
aspire/eng/pipelines/azure-pipelines-public.yml
Lines 102 to 103 in 2344aaf
| # timeout accounts for wait times for helix agents up to 30mins | |
| timeoutInMinutes: 90 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test run on this PR took ~8mins. If this is taking up to an hour sometimes then maybe we need to investigate why that is the case.
Description
Adds
WaitForsupport for ElasticsearchRelated: #5645
Checklist
<remarks />and<code />elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow