Skip to content

Add cgmanifest.json for templates dependencies #4841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Add cgmanifest.json for templates dependencies #4841

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96720d1
Add cgmanifest.json for templates dependencies
sebastienros Jul 10, 2024
04989aa
Remove Microsoft.Extensions.ServiceDiscovery
sebastienros Jul 10, 2024
d677d0c
Merge remote-tracking branch 'origin/main' into sebros/cgmanifest
sebastienros Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
141 changes: 141 additions & 0 deletions src/Aspire.ProjectTemplates/cgmanifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,141 @@
{
"$schema": "https://json.schemastore.org/component-detection-manifest.json",
"version": 1,
"registrations": [
{
"component": {
"type": "nuget",
"nuget": {
"name": "OpenTelemetry.Exporter.OpenTelemetryProtocol",
"version": "1.9.0"
}
}
},
{
"component": {
"type": "nuget",
"nuget": {
"name": "OpenTelemetry.Extensions.Hosting",
"version": "1.9.0"
}
}
},
{
"component": {
"type": "nuget",
"nuget": {
"name": "OpenTelemetry.Instrumentation.AspNetCore",
"version": "1.9.0"
}
}
},
{
"component": {
"type": "nuget",
"nuget": {
"name": "OpenTelemetry.Instrumentation.Http",
"version": "1.9.0"
}
}
},
{
"component": {
"type": "nuget",
"nuget": {
"name": "OpenTelemetry.Instrumentation.Runtime",
"version": "1.9.0"
}
}
},
{
"component": {
"type": "nuget",
"nuget": {
"name": "Microsoft.Extensions.Http.Resilience",
"version": "8.6.0"
}
}
},
{
"component": {
"type": "nuget",
"nuget": {
"name": "Microsoft.Extensions.ServiceDiscovery",
Copy link
Member

@eerhardt eerhardt Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is built from dotnet/aspire. Should it be here?

Copy link
Member Author

@sebastienros sebastienros Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used directly from the templates, so I think this should be added just because we know it's a direct dependency. Unless we say we already use it so we don't have to add it. IMO it doesn't hurt to keep it there.

https://github.com/dotnet/aspire/blob/main/src/Aspire.ProjectTemplates/templates/aspire-empty/AspireApplication.1.ServiceDefaults/AspireApplication.1.ServiceDefaults.csproj#L14

Copy link
Member Author

@sebastienros sebastienros Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand what you meant now, found the project, removing

Copy link
Member

@danmoseley danmoseley Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having it here will flag if somehow the templates do not point at the latest version. (Presumably because our script has a problem?)

Copy link
Member Author

@sebastienros sebastienros Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am currently trying to update the files such that we don't have static versions in the project templates but use Directory.Packages.props

Copy link
Member Author

@sebastienros sebastienros Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find a good way to centrally manage it so only removing this dependency for now.
It's part of the solution to there is no reason to add it to cgmanifest, we don't set the version manually, it's automated on build so it will never be a different version.

"version": "8.6.0"
}
}
},
{
"component": {
"type": "nuget",
"nuget": {
"name": "Microsoft.NET.Test.Sdk",
"version": "17.10.0"
}
}
},
{
"component": {
"type": "nuget",
"nuget": {
"name": "MSTest",
"version": "3.4.3"
}
}
},
{
"component": {
"type": "nuget",
"nuget": {
"name": "coverlet.collector",
"version": "6.0.2"
}
}
},
{
"component": {
"type": "nuget",
"nuget": {
"name": "NUnit",
"version": "4.1.0"
}
}
},
{
"component": {
"type": "nuget",
"nuget": {
"name": "NUnit.Analyzers",
"version": "4.2.0"
}
}
},
{
"component": {
"type": "nuget",
"nuget": {
"name": "NUnit3TestAdapter",
"version": "4.5.0"
}
}
},
{
"component": {
"type": "nuget",
"nuget": {
"name": "xunit",
"version": "2.9.0"
}
}
},
{
"component": {
"type": "nuget",
"nuget": {
"name": "xunit.runner.visualstudio",
"version": "2.8.2"
}
}
}
]
}