Skip to content

Change GetHostAddressExpression from explicit interface implementation to public method #14319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eric Erhardt (eerhardt) merged 3 commits into from
Feb 4, 2026
Merged

Change GetHostAddressExpression from explicit interface implementation to public method #14319

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1806314
Initial plan
Copilot Feb 3, 2026
f124cea
Change GetHostAddressExpression implementations to public methods
Copilot Feb 3, 2026
9a3954a
Add Experimental attribute to GetHostAddressExpression methods
Copilot Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppEnvironmentResource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,8 @@ public AzureContainerRegistryResource? ContainerRegistry
ReferenceExpression IAzureContainerRegistry.ManagedIdentityId => ReferenceExpression.Create($"{ContainerRegistryManagedIdentityId}");
#pragma warning restore CS0618 // Type or member is obsolete

ReferenceExpression IComputeEnvironmentResource.GetHostAddressExpression(EndpointReference endpointReference)
/// <inheritdoc/>
public ReferenceExpression GetHostAddressExpression(EndpointReference endpointReference)
Comment thread
eerhardt marked this conversation as resolved.
{
var resource = endpointReference.Resource;

Expand Down
3 changes: 2 additions & 1 deletion src/Aspire.Hosting.Azure.AppService/AzureAppServiceEnvironmentResource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,8 @@ public AzureContainerRegistryResource? ContainerRegistry
ReferenceExpression IAzureContainerRegistry.ManagedIdentityId => ReferenceExpression.Create($"{ContainerRegistryManagedIdentityId}");
#pragma warning restore CS0618 // Type or member is obsolete

ReferenceExpression IComputeEnvironmentResource.GetHostAddressExpression(EndpointReference endpointReference)
/// <inheritdoc/>
public ReferenceExpression GetHostAddressExpression(EndpointReference endpointReference)
{
var resource = endpointReference.Resource;
return ReferenceExpression.Create($"{resource.Name.ToLowerInvariant()}-{WebSiteSuffix}.azurewebsites.net");
Expand Down
8 changes: 2 additions & 6 deletions src/Aspire.Hosting.Docker/DockerComposeEnvironmentResource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,12 +185,8 @@ public DockerComposeEnvironmentResource(string name) : base(name)
}));
}

/// <summary>
/// Computes the host URL <see cref="ReferenceExpression"/> for the given <see cref="EndpointReference"/>.
/// </summary>
/// <param name="endpointReference">The endpoint reference to compute the host address for.</param>
/// <returns>A <see cref="ReferenceExpression"/> representing the host address.</returns>
ReferenceExpression IComputeEnvironmentResource.GetHostAddressExpression(EndpointReference endpointReference)
/// <inheritdoc/>
public ReferenceExpression GetHostAddressExpression(EndpointReference endpointReference)
{
var resource = endpointReference.Resource;

Expand Down
8 changes: 2 additions & 6 deletions src/Aspire.Hosting.Kubernetes/KubernetesEnvironmentResource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,8 @@ public KubernetesEnvironmentResource(string name) : base(name)
}));
}

/// <summary>
/// Computes the host URL <see cref="ReferenceExpression"/> for the given <see cref="EndpointReference"/>.
/// </summary>
/// <param name="endpointReference">The endpoint reference to compute the host address for.</param>
/// <returns>A <see cref="ReferenceExpression"/> representing the host address.</returns>
ReferenceExpression IComputeEnvironmentResource.GetHostAddressExpression(EndpointReference endpointReference)
/// <inheritdoc/>
public ReferenceExpression GetHostAddressExpression(EndpointReference endpointReference)
{
var resource = endpointReference.Resource;

Expand Down
2 changes: 1 addition & 1 deletion tests/Aspire.Hosting.Azure.Tests/AzureAppServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,7 +754,7 @@ public async Task GetHostAddressExpression()
.AddProject<Project>("project1", launchProfileName: null)
.WithHttpEndpoint();

var endpointReferenceEx = ((IComputeEnvironmentResource)env.Resource).GetHostAddressExpression(project.GetEndpoint("http"));
var endpointReferenceEx = env.Resource.GetHostAddressExpression(project.GetEndpoint("http"));
Assert.NotNull(endpointReferenceEx);

Assert.Equal("project1-{0}.azurewebsites.net", endpointReferenceEx.Format);
Expand Down
2 changes: 1 addition & 1 deletion tests/Aspire.Hosting.Azure.Tests/AzureContainerAppsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2099,7 +2099,7 @@ public async Task GetHostAddressExpression()
.AddProject<Project>("project1", launchProfileName: null)
.WithHttpEndpoint();

var endpointReferenceEx = ((IComputeEnvironmentResource)env.Resource).GetHostAddressExpression(project.GetEndpoint("http"));
var endpointReferenceEx = env.Resource.GetHostAddressExpression(project.GetEndpoint("http"));
Assert.NotNull(endpointReferenceEx);

Assert.Equal("project1.internal.{0}", endpointReferenceEx.Format);
Expand Down
2 changes: 1 addition & 1 deletion tests/Aspire.Hosting.Docker.Tests/DockerComposeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ public async Task GetHostAddressExpression()
.AddProject<Projects.ServiceA>("Project1", launchProfileName: null)
.WithHttpEndpoint();

var endpointReferenceEx = ((IComputeEnvironmentResource)env.Resource).GetHostAddressExpression(project.GetEndpoint("http"));
var endpointReferenceEx = env.Resource.GetHostAddressExpression(project.GetEndpoint("http"));
Assert.NotNull(endpointReferenceEx);

Assert.Equal("project1", endpointReferenceEx.Format);
Expand Down
2 changes: 1 addition & 1 deletion tests/Aspire.Hosting.Kubernetes.Tests/KubernetesEnvironmentResourceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public async Task GetHostAddressExpression()
.AddProject<Projects.ServiceA>("project1", launchProfileName: null)
.WithHttpEndpoint();

var endpointReferenceEx = ((IComputeEnvironmentResource)env.Resource).GetHostAddressExpression(project.GetEndpoint("http"));
var endpointReferenceEx = env.Resource.GetHostAddressExpression(project.GetEndpoint("http"));
Assert.NotNull(endpointReferenceEx);

Assert.Equal("project1-service", endpointReferenceEx.Format);
Expand Down
Loading